commit | 421584173cae282ee496291b1cb08eebcad71be7 | [log] [tgz] |
---|---|---|
author | Yan, Shaobo <shaobo.yan@intel.com> | Wed Aug 07 18:20:33 2019 +0000 |
committer | Commit Bot service account <commit-bot@chromium.org> | Wed Aug 07 18:20:33 2019 +0000 |
tree | 5bbfd0b3b5a16b296e2b417f0c742b1ce7f77b81 | |
parent | 1cd83ffbdd5d5f870f57398768555d3d97068177 [diff] |
Fix dynamic buffer offset issues on D3D12 backend This patch fixes 1. Inherit dynamic buffer offsets : dawn chooses vulkan like inherit behaviour, so dynamic offsets need to be inherited. This patch adds inherit dynamic offsets between pipelines support and adds tests to cover it. 2. Dynamic offsets are skipped when groups have been set : in D3D12 backend, when invoke SetBindGroup, dawn will check whether this group has already been set and skip updating root signature if the answer is yes. However, this behaviour will affect dynamic offsets update. With the latest patch, we always update dynamic offsets, even if they didn't change and adds tests to cover it. This patch also hit a dawn's issue about storage buffer validation in compute pass. Currently the validation is a workaround to avoid access conflicts but will impact using dynamic buffer offset in compute pipeline. Fix this issue is hard so disable related test for now and will enable it after the issue been fixed. File dawn bug 198 to track this BUG=dawn:55 Change-Id: I2b0f179b3555d37d5b350292eb729767b0d60ab6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9621 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Dawn (formerly NXT) is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. It exposes a C/C++ API that maps almost one-to-one to the WebGPU IDL and can be managed as part of a larger system such as a Web browser.
Dawn provides several WebGPU building blocks:
dawn.json
: description of the API used to drive code generators.examples
: examples showing how Dawn is used.generator
: code generator for files produces from dawn.json
templates
: Jinja2 templates for the generatorscripts
: scripts to support things like continuous testing, build files, etc.src
:common
: helper code shared between core Dawn libraries and tests/samplesdawn_native
: native implementation of WebGPU, one subfolder per backenddawn_wire
: client-server implementation of WebGPUinclude
: public headers for Dawntests
: internal Dawn testsend2end
: WebGPU tests performing GPU operationsunittests
: unittests and by extension tests not using the GPUvalidation
: WebGPU validation tests not using the GPU (frontend tests)utils
: helper code to use Dawn used by tests and samplesthird_party
: directory where dependencies live as well as their buildfiles.Dawn uses the Chromium build system and dependency management so you need to install depot_tools and add it to the PATH.
On Linux you need to have the pkg-config
command:
# Install pkg-config on Ubuntu sudo apt-get install pkg-config
Then get the source as follows:
# Clone the repo as "dawn" git clone https://dawn.googlesource.com/dawn dawn && cd dawn # Bootstrap the gclient configuration cp scripts/standalone.gclient .gclient # Fetch external dependencies and toolchains with gclient gclient sync
Then generate build files using gn args out/Debug
or gn args out/Release
. A text editor will appear asking build options, the most common option is is_debug=true/false
; otherwise gn args out/Release --list
shows all the possible options.
Then use ninja -C out/Release
to build dawn and for example ./out/Release/dawn_end2end_tests
to run the tests.
Please read and follow CONTRIBUTING.md. Dawn doesn‘t have a formal coding style yet, except what’s defined by our clang format style. Overall try to use the same style and convention as code around your change.
If you find issues with Dawn, please feel free to report them on the bug tracker. For other discussions, please post to Dawn's mailing list.
Please see LICENSE.
This is not an officially supported Google product.