commit 4500fc4d17251ca88752afc5c6dad722c5b58ce4
author Michael Ludwig <michaelludwig@google.com> Wed Jun 11 13:35:16 2025 -0700
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jun 11 13:35:16 2025 -0700
tree 1643ece1be4a2d60ebdbdc9c7eacb8aa60ba9704
parent 7f3cb94be0b3a948ea54338c54a0227fce6378ad

[metal] Fix simulator check for disabling framebuffer fetch

Change-Id: I082f9d9790254c5eeae0dea4a504a0f8011809c0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/246454
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/dawn/native/metal/PhysicalDeviceMTL.mm

diff --git a/src/dawn/native/metal/PhysicalDeviceMTL.mm b/src/dawn/native/metal/PhysicalDeviceMTL.mm
index 4366dd5..7904642 100644
--- a/src/dawn/native/metal/PhysicalDeviceMTL.mm
+++ b/src/dawn/native/metal/PhysicalDeviceMTL.mm
@@ -650,7 +650,8 @@
     // family of GPUs on.
     if ([*mDevice supportsFamily:MTLGPUFamilyApple2]) {
         // Programmable blending doesn't seem to work as expected on the iOS simulator.
-#if !defined(TARGET_OS_SIMULATOR)
+        // NOTE: TARGET_OS_SIMULATOR can be defined but set to false for MacOS builds.
+#if !defined(TARGET_OS_SIMULATOR) || !TARGET_OS_SIMULATOR
         EnableFeature(Feature::FramebufferFetch);
 #endif
         EnableFeature(Feature::TransientAttachments);