[tint] Remove exit(1) from ICE handler
Now that ICEs always abort(), we don't need to exit from the
handler. This has the advantage that the Tint executable will actually
crash at the point of an ICE, which makes debugging much easier.
Change-Id: Ia1aae0ac418bab73ae4cf3da0ea313e834be7885
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/188622
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: James Price <jrprice@google.com>
diff --git a/src/tint/cmd/common/helper.cc b/src/tint/cmd/common/helper.cc
index 9f83e9a..0fd37f8 100644
--- a/src/tint/cmd/common/helper.cc
+++ b/src/tint/cmd/common/helper.cc
@@ -149,7 +149,7 @@
} // namespace
-[[noreturn]] void TintInternalCompilerErrorReporter(const InternalCompilerError& err) {
+void TintInternalCompilerErrorReporter(const InternalCompilerError& err) {
auto printer = StyledTextPrinter::Create(stderr);
StyledText msg;
msg << (style::Error + style::Bold) << err.Error();
@@ -162,7 +162,6 @@
********************************************************************
)";
printer->Print(msg);
- exit(1);
}
void PrintWGSL(std::ostream& out, const tint::Program& program) {
diff --git a/src/tint/cmd/common/helper.h b/src/tint/cmd/common/helper.h
index dbc8e38..0bfb820 100644
--- a/src/tint/cmd/common/helper.h
+++ b/src/tint/cmd/common/helper.h
@@ -57,7 +57,7 @@
};
/// Reporter callback for internal tint errors
-[[noreturn]] void TintInternalCompilerErrorReporter(const InternalCompilerError& err);
+void TintInternalCompilerErrorReporter(const InternalCompilerError& err);
/// PrintWGSL writes the WGSL of the program to the provided ostream, if the
/// WGSL writer is enabled, otherwise it does nothing.
