Make adapter info device matching more flexible
Previously all of the device IDs I was aware of for a given vendor could
be comfortably filtered with a single mask, but there's at least one
exception that has come up since that indicates that support for
multiple different masks per vendor is necessary.
This change allows devices to be identified in groups, with each group
being given a different mask or no mask at all. Architectures may be
shared between groups.
Also added the ability to mark a device group as internal, which will
generate the helper functions (like `IsVendorArchitecture()`) for the
internal architectures but not allow them to be exposed in
GPUAdapterInfo. Internal device IDs may overlap with non-internal ones.
Finally, added some validation logic to prevent duplicate deviceIds or
conflicts between device sets/architectures. This was actually supposed
to be in an earlier CL but somehow got omitted from the version that
eventually landed.
Bug: dawn:1498
Change-Id: Icb8bfbee47324cbd9791f63089877ace86c763db
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96900
Reviewed-by: Yunchao He <yunchao.he@intel.com>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
diff --git a/generator/dawn_gpu_info_generator.py b/generator/dawn_gpu_info_generator.py
index 31b1eb5..c059afb 100644
--- a/generator/dawn_gpu_info_generator.py
+++ b/generator/dawn_gpu_info_generator.py
@@ -19,6 +19,12 @@
from generator_lib import Generator, run_generator, FileRender
+def parse_mask(mask):
+ if mask:
+ return int(mask, 0)
+ return 0xffffffff
+
+
class Name:
def __init__(self, name):
self.name = name
@@ -59,45 +65,136 @@
class Architecture:
- def __init__(self, name, json_data):
+ def __init__(self, name, json_data, mask):
self.name = Name(name)
self.devices = []
+
+ mask_num = parse_mask(mask)
+
for device in json_data:
+ device_num = int(device, 0)
+
+ # Don't allow duplicate entries
+ assert device not in self.devices, 'Architecture "{}" contained duplicate deviceID "{}"'.format(
+ self.name.get(), device)
+ # Ensure that all device IDs don't contain bits outside the mask
+ assert device_num & mask_num == device_num, 'Architecture "{}" contained deviceID "{}" which doesn\'t match the given mask of "{}"'.format(
+ self.name.get(), device, mask)
+
self.devices.append(device)
+class DeviceSet:
+ def __init__(self, json_data):
+ self.mask = None
+ self.internal = False
+
+ if 'mask' in json_data:
+ self.mask = json_data['mask']
+
+ if 'internal' in json_data:
+ self.internal = json_data['internal']
+
+ self.architectures = []
+ if 'architecture' in json_data:
+ for (arch_name, arch_data) in json_data['architecture'].items():
+ # Skip any entries that start with an underscore. Used for comments.
+ if arch_name[0] == '_':
+ continue
+
+ architecture = Architecture(arch_name, arch_data, self.mask)
+
+ # Validate that deviceIDs are only allowed to be in one Architecture at a time
+ for other_architecture in self.architectures:
+ for device in architecture.devices:
+ assert device not in other_architecture.devices, 'Architectures "{}" and "{}" both contain deviceID "{}"'.format(
+ architecture.name.get(),
+ other_architecture.name.get(), device)
+
+ self.architectures.append(architecture)
+
+ def validate_devices(self, other_devices, other_mask):
+ combined_mask = parse_mask(self.mask) & parse_mask(other_mask)
+
+ for other_device in other_devices:
+ other_device_num = int(other_device, 0) & combined_mask
+ for architecture in self.architectures:
+ for device in architecture.devices:
+ device_num = int(device, 0) & combined_mask
+ assert device_num != other_device_num, 'DeviceID "{}" & mask "{}" conflicts with deviceId "{}" & mask "{}" in architecture "{}"'.format(
+ other_device, other_mask, device, self.mask,
+ architecture.name.get())
+
+ def maskDeviceId(self):
+ if not self.mask:
+ return ''
+ return ' & ' + self.mask
+
+
class Vendor:
def __init__(self, name, json_data):
self.name = Name(name)
self.id = json_data['id']
- self.deviceMask = None
- if 'deviceMask' in json_data:
- self.deviceMask = json_data['deviceMask']
+ architecture_dict = {}
+ internal_architecture_dict = {}
- self.architectures = []
+ self.device_sets = []
+ if 'devices' in json_data:
+ for device_data in json_data['devices']:
+ device_set = DeviceSet(device_data)
- if 'architecture' in json_data:
- for (arch_name, arch_data) in json_data['architecture'].items():
- # Skip any entries that start with an underscore. Used for comments.
- if arch_name[0] == '_':
- continue
+ for architecture in device_set.architectures:
- self.architectures.append(Architecture(arch_name, arch_data))
+ # Validate that deviceIDs are unique across device sets
+ for other_device_set in self.device_sets:
+ # Only validate device IDs between internal and public device sets.
+ if other_device_set.internal == device_set.internal:
+ assert device_set.mask != other_device_set.mask, 'Vendor "{}" contained duplicate device masks "{}"'.format(
+ self.name.get(), device_set.mask)
+ other_device_set.validate_devices(
+ architecture.devices, device_set.mask)
- def maskDeviceId(self):
- if not self.deviceMask:
- return ''
- return ' & ' + self.deviceMask
+ # Validate that architecture names are unique between internal and public device sets.
+ else:
+ for other_architecture in other_device_set.architectures:
+ assert architecture.name.canonical_case(
+ ) != other_architecture.name.canonical_case(
+ ), '"{}" is defined as both an internal and public architecture'.format(
+ architecture.name.get())
+
+ if device_set.internal:
+ internal_architecture_dict[
+ architecture.name.canonical_case(
+ )] = architecture.name
+ else:
+ architecture_dict[architecture.name.canonical_case(
+ )] = architecture.name
+
+ self.device_sets.append(device_set)
+
+ # List of unique architecture names under this vendor
+ self.architecture_names = architecture_dict.values()
+ self.internal_architecture_names = internal_architecture_dict.values()
def parse_json(json):
vendors = []
+ internal_architecture_count = 0
- for (vendor, vendor_data) in json['vendors'].items():
- vendors.append(Vendor(vendor, vendor_data))
+ for (vendor_name, vendor_data) in json['vendors'].items():
+ # Skip vendors that have a leading underscore. Those are intended to be "comments".
+ if vendor_name[0] == '_':
+ continue
- return {'vendors': vendors}
+ vendor = Vendor(vendor_name, vendor_data)
+ vendors.append(vendor)
+ internal_architecture_count += len(vendor.internal_architecture_names)
+
+ return {
+ 'vendors': vendors,
+ 'has_internal': internal_architecture_count > 0
+ }
class DawnGpuInfoGenerator(Generator):
diff --git a/generator/templates/dawn/common/GPUInfo.cpp b/generator/templates/dawn/common/GPUInfo.cpp
index 49ea9a4..f24c262 100644
--- a/generator/templates/dawn/common/GPUInfo.cpp
+++ b/generator/templates/dawn/common/GPUInfo.cpp
@@ -28,8 +28,8 @@
enum class Architecture {
Unknown,
{% for vendor in vendors %}
- {% for architecture in vendor.architectures %}
- {{vendor.name.CamelCase()}}_{{architecture.name.CamelCase()}},
+ {% for architecture_name in vendor.architecture_names %}
+ {{vendor.name.CamelCase()}}_{{architecture_name.CamelCase()}},
{% endfor %}
{% endfor %}
};
@@ -37,17 +37,20 @@
Architecture GetArchitecture(PCIVendorID vendorId, PCIDeviceID deviceId) {
switch(vendorId) {
{% for vendor in vendors %}
- {% if len(vendor.architectures) %}
-
+ {% if len(vendor.device_sets) %}
case kVendorID_{{vendor.name.CamelCase()}}: {
- switch (deviceId{{vendor.maskDeviceId()}}) {
- {% for architecture in vendor.architectures %}
- {% for device in architecture.devices %}
- case {{device}}:
- {% endfor %}
- return Architecture::{{vendor.name.CamelCase()}}_{{architecture.name.CamelCase()}};
- {% endfor %}
- }
+ {% for device_set in vendor.device_sets %}
+ {% if not device_set.internal %}
+ switch (deviceId{{device_set.maskDeviceId()}}) {
+ {% for architecture in device_set.architectures %}
+ {% for device in architecture.devices %}
+ case {{device}}:
+ {% endfor %}
+ return Architecture::{{vendor.name.CamelCase()}}_{{architecture.name.CamelCase()}};
+ {% endfor %}
+ }
+ {% endif %}
+ {% endfor %}
} break;
{% endif %}
{% endfor %}
@@ -56,6 +59,44 @@
return Architecture::Unknown;
}
+{% if has_internal %}
+
+ enum class InternalArchitecture {
+ Unknown,
+ {% for vendor in vendors %}
+ {% for architecture_name in vendor.internal_architecture_names %}
+ {{vendor.name.CamelCase()}}_{{architecture_name.CamelCase()}},
+ {% endfor %}
+ {% endfor %}
+ };
+
+ InternalArchitecture GetInternalArchitecture(PCIVendorID vendorId, PCIDeviceID deviceId) {
+ switch(vendorId) {
+ {% for vendor in vendors %}
+ {% if len(vendor.device_sets) %}
+ case kVendorID_{{vendor.name.CamelCase()}}: {
+ {% for device_set in vendor.device_sets %}
+ {% if device_set.internal %}
+ switch (deviceId{{device_set.maskDeviceId()}}) {
+ {% for architecture in device_set.architectures %}
+ {% for device in architecture.devices %}
+ case {{device}}:
+ {% endfor %}
+ return InternalArchitecture::{{vendor.name.CamelCase()}}_{{architecture.name.CamelCase()}};
+ {% endfor %}
+ }
+ {% endif %}
+ {% endfor %}
+ } break;
+ {% endif %}
+ {% endfor %}
+ }
+
+ return InternalArchitecture::Unknown;
+ }
+
+{% endif %}
+
} // namespace
// Vendor checks
@@ -68,11 +109,16 @@
// Architecture checks
{% for vendor in vendors %}
- {% if len(vendor.architectures) %}
+ {% if len(vendor.architecture_names) %}
// {{vendor.name.get()}} architectures
- {% for architecture in vendor.architectures %}
- bool Is{{vendor.name.CamelCase()}}{{architecture.name.CamelCase()}}(PCIVendorID vendorId, PCIDeviceID deviceId) {
- return GetArchitecture(vendorId, deviceId) == Architecture::{{vendor.name.CamelCase()}}_{{architecture.name.CamelCase()}};
+ {% for architecture_name in vendor.architecture_names %}
+ bool Is{{vendor.name.CamelCase()}}{{architecture_name.CamelCase()}}(PCIVendorID vendorId, PCIDeviceID deviceId) {
+ return GetArchitecture(vendorId, deviceId) == Architecture::{{vendor.name.CamelCase()}}_{{architecture_name.CamelCase()}};
+ }
+ {% endfor %}
+ {% for architecture_name in vendor.internal_architecture_names %}
+ bool Is{{vendor.name.CamelCase()}}{{architecture_name.CamelCase()}}(PCIVendorID vendorId, PCIDeviceID deviceId) {
+ return GetInternalArchitecture(vendorId, deviceId) == InternalArchitecture::{{vendor.name.CamelCase()}}_{{architecture_name.CamelCase()}};
}
{% endfor %}
{% endif %}
@@ -95,9 +141,9 @@
case Architecture::Unknown:
return "";
{% for vendor in vendors %}
- {% for architecture in vendor.architectures %}
- case Architecture::{{vendor.name.CamelCase()}}_{{architecture.name.CamelCase()}}:
- return "{{architecture.name.js_enum_case()}}";
+ {% for architecture_name in vendor.architecture_names %}
+ case Architecture::{{vendor.name.CamelCase()}}_{{architecture_name.CamelCase()}}:
+ return "{{architecture_name.js_enum_case()}}";
{% endfor %}
{% endfor %}
}
diff --git a/generator/templates/dawn/common/GPUInfo.h b/generator/templates/dawn/common/GPUInfo.h
index f4a54e0..f058008 100644
--- a/generator/templates/dawn/common/GPUInfo.h
+++ b/generator/templates/dawn/common/GPUInfo.h
@@ -35,11 +35,14 @@
// Architecture checks
{% for vendor in vendors %}
- {% if len(vendor.architectures) %}
+ {% if len(vendor.architecture_names) %}
// {{vendor.name.get()}} architectures
- {% for architecture in vendor.architectures %}
- bool Is{{vendor.name.CamelCase()}}{{architecture.name.CamelCase()}}(PCIVendorID vendorId, PCIDeviceID deviceId);
+ {% for architecture_name in vendor.architecture_names %}
+ bool Is{{vendor.name.CamelCase()}}{{architecture_name.CamelCase()}}(PCIVendorID vendorId, PCIDeviceID deviceId);
+ {% endfor %}
+ {% for architecture_name in vendor.internal_architecture_names %}
+ bool Is{{vendor.name.CamelCase()}}{{architecture_name.CamelCase()}}(PCIVendorID vendorId, PCIDeviceID deviceId);
{% endfor %}
{% endif %}
{% endfor %}
