commit 494552b886620ef7cc27e9c201a2c9a5a3db74bf
author Yunchao He <yunchao.he@intel.com> Thu Mar 28 10:57:41 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Thu Mar 28 10:57:41 2019 +0000
tree 8807129ec25101ab2d63d2b022986881a398794c
parent d754fb2034660e472b624cb05f095ac871c90e11

Some small optimizations and style issues for input state

Bug=dawn:107

Change-Id: I8ecfb39a2bff11b678bd8548ec0725ba061ef333
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6081
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>

src/dawn_native/opengl/RenderPipelineGL.cpp

diff --git a/src/dawn_native/opengl/RenderPipelineGL.cpp b/src/dawn_native/opengl/RenderPipelineGL.cpp
index 991b022..f729370 100644
--- a/src/dawn_native/opengl/RenderPipelineGL.cpp
+++ b/src/dawn_native/opengl/RenderPipelineGL.cpp
@@ -197,12 +197,8 @@
     void RenderPipeline::CreateVAOForInputState(const InputStateDescriptor* inputState) {
         glGenVertexArrays(1, &mVertexArrayObject);
         glBindVertexArray(mVertexArrayObject);
-        auto& attributesSetMask = GetAttributesSetMask();
-        for (uint32_t location = 0; location < attributesSetMask.size(); ++location) {
-            if (!attributesSetMask[location]) {
-                continue;
-            }
-            auto attribute = GetAttribute(location);
+        for (uint32_t location : IterateBitSet(GetAttributesSetMask())) {
+            const auto& attribute = GetAttribute(location);
             glEnableVertexAttribArray(location);
 
             attributesUsingInput[attribute.inputSlot][location] = true;