commit 4953dabab732b87f39ac70dbe9033a75e9c913e3
author Ben Clayton <bclayton@google.com> Wed Sep 21 16:42:34 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 21 16:42:34 2022 +0000
tree bdf78ddba562edcfb97880555994e046feb311df
parent 849dff2adacf413c4955163c4bafb166f7aea2b6

dawn/tests: Remove OverridesWithZeroDefault test

It's not invalid to have create a shader module using zero-defaulted `override`s as workgroup size parameters.
These can be initialized with non-zero pipeline override values.

Bug: dawn:1504
Change-Id: I2636cbe2d26a6604735b0c8b0f5526bbc14e8ce2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103220
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/dawn/tests/end2end/ShaderValidationTests.cpp

diff --git a/src/dawn/tests/end2end/ShaderValidationTests.cpp b/src/dawn/tests/end2end/ShaderValidationTests.cpp
index e2e4365..302a6ba 100644
--- a/src/dawn/tests/end2end/ShaderValidationTests.cpp
+++ b/src/dawn/tests/end2end/ShaderValidationTests.cpp
@@ -37,17 +37,6 @@
 })");
     }
 
-    wgpu::ShaderModule SetUpShaderWithZeroDefaultValueConstants() {
-        return utils::CreateShaderModule(device, R"(
-override x: u32 = 0u;
-override y: u32 = 0u;
-override z: u32 = 0u;
-
-@compute @workgroup_size(x, y, z) fn main() {
-    _ = 0u;
-})");
-    }
-
     wgpu::ShaderModule SetUpShaderWithOutOfLimitsDefaultValueConstants() {
         return utils::CreateShaderModule(device, R"(
 override x: u32 = 1u;
@@ -237,12 +226,6 @@
     }
 }
 
-// Test workgroup size validation with zero as the overrides default values.
-TEST_P(WorkgroupSizeValidationTest, OverridesWithZeroDefault) {
-    // Error: zero is detected as invalid at shader creation time
-    ASSERT_DEVICE_ERROR(SetUpShaderWithZeroDefaultValueConstants());
-}
-
 // Test workgroup size validation with out-of-limits overrides default values.
 TEST_P(WorkgroupSizeValidationTest, OverridesWithOutOfLimitsDefault) {
     wgpu::ShaderModule module = SetUpShaderWithOutOfLimitsDefaultValueConstants();