Change check to assert for VVL error
On WebView we are receiving VVL errors from the driver when Vulkan
object labels are disabled. This results in a DAWN_CHECK failing and
WebView crashing. It's not entirely clear why the driver is sending
messages with VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT set, as VVL
should be disabled in release builds, but there is some discussion in
the bug.
Either way the error handler is just to alert developers that something
is wrong. Change it back to DAWN_ASSERT() to avoid crashing in release
builds.
Bug: 397098430
Change-Id: I9a9afc76a2a27de4641ed658a250518c5d4aa52c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/226678
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@google.com>
diff --git a/src/dawn/native/vulkan/BackendVk.cpp b/src/dawn/native/vulkan/BackendVk.cpp
index fb0046f..6019133 100644
--- a/src/dawn/native/vulkan/BackendVk.cpp
+++ b/src/dawn/native/vulkan/BackendVk.cpp
@@ -31,6 +31,7 @@
#include <string>
#include <utility>
+#include "dawn/common/Assert.h"
#include "dawn/common/BitSetIterator.h"
#include "dawn/common/Log.h"
#include "dawn/common/SystemUtils.h"
@@ -336,7 +337,7 @@
// driver can also produce errors even with backend validation disabled so those errors are
// just logged.
LogCallbackData(LogSeverity::Error, pCallbackData);
- DAWN_CHECK(!(messageTypes & VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT));
+ DAWN_ASSERT(!(messageTypes & VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT));
return VK_FALSE;
}
