commit 4c5a9c1ef72f16941fe0c4444e91cf012200fbf1
author Corentin Wallez <cwallez@chromium.org> Tue Dec 06 13:37:21 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 06 13:37:21 2022 +0000
tree 7ee97416f17fecd4315c6b8759f7fc6e5d3c921d
parent 9f7c06ce147c28cadf6ebf735cfde8de6832e4b2

node: Throw a TypeError when writeTimestamp is not supported

Bug: None
Change-Id: I7e02883c53371c40a9e1766d50550ffc43165c2e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112425
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

src/dawn/node/binding/GPUCommandEncoder.cpp

diff --git a/src/dawn/node/binding/GPUCommandEncoder.cpp b/src/dawn/node/binding/GPUCommandEncoder.cpp
index 8e38168..87fa612 100644
--- a/src/dawn/node/binding/GPUCommandEncoder.cpp
+++ b/src/dawn/node/binding/GPUCommandEncoder.cpp
@@ -173,6 +173,12 @@
 void GPUCommandEncoder::writeTimestamp(Napi::Env env,
                                        interop::Interface<interop::GPUQuerySet> querySet,
                                        interop::GPUSize32 queryIndex) {
+    if (!device_.HasFeature(wgpu::FeatureName::TimestampQuery)) {
+        Napi::TypeError::New(env, "timestamp-query feature is not enabled.")
+            .ThrowAsJavaScriptException();
+        return;
+    }
+
     Converter conv(env);
 
     wgpu::QuerySet q{};