Upgrade the version of go used in CI
The slices package was added in Go 1.21, but CI scripts tried to use 1.18. This switched to 1.23 because only the 2 most recent major Go releases are supported officially.
PS: I know, there are other issues in the CI, one is just about [fixing `fetch_dawn_dependencies.py`](https://github.com/google/dawn/compare/main...eliemichel:dawn-prebuilt:eliemichel/fix-fetch-deps) but then we still have undefined symbols in macOS build:
```
ld: Undefined symbols:
tint::ast::transform::SubstituteOverride::Config::Config(tint::ast::transform::SubstituteOverride::Config const&), referenced from:
tint::ast::transform::SubstituteOverride::Config* std::__1::construct_at[abi:v160006]<tint::ast::transform::SubstituteOverride::Config, tint::ast::transform::SubstituteOverride::Config, tint::ast::transform::SubstituteOverride::Config*>(tint::ast::transform::SubstituteOverride::Config*, tint::ast::transform::SubstituteOverride::Config&&) in ShaderModuleMTL.mm.o
tint::ast::transform::SubstituteOverride::Config::Config(), referenced from:
dawn::native::BuildSubstituteOverridesTransformConfig(dawn::native::ProgrammableStage const&) in TintUtils.cpp.o
tint::ast::transform::SubstituteOverride::Config::~Config(), referenced from:
dawn::native::BuildSubstituteOverridesTransformConfig(dawn::native::ProgrammableStage const&) in TintUtils.cpp.o
...
```
[(Full GitHub Action log)](https://github.com/eliemichel/dawn-prebuilt/actions/runs/14455086325/job/40536396834)
Should I share fixes one at a time or rather try and pack everything into the same commit?
This is an imported pull request from
https://github.com/google/dawn/pull/32
GITHUB_PR_HEAD_SHA=dffe310a2e36d5ee89b6ba0ca28a50d9dc3969bc
ORIGINAL_AUTHOR=Elie Michel <eliemichel@users.noreply.github.com>
GitOrigin-RevId: 2a8348f73838a001be8c63b4ed1a600395df4564
Change-Id: I62d1c39592a8c4b3adbf751161aaa7caf77c6c4b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/236934
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 56f1812..a3df2da 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -146,7 +146,7 @@
- name: Set up Go
uses: actions/setup-go@v4
with:
- go-version: '1.18'
+ go-version: '1.23'
- name: Build
run: go build -v ./...
diff --git a/go.mod b/go.mod
index b9868c4..7537c55 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,6 @@
module dawn.googlesource.com/dawn
-go 1.18
+go 1.23.0
require (
cloud.google.com/go/bigquery v1.52.0
diff --git a/tools/fetch_dawn_dependencies.py b/tools/fetch_dawn_dependencies.py
index b5594de..6894b6d 100644
--- a/tools/fetch_dawn_dependencies.py
+++ b/tools/fetch_dawn_dependencies.py
@@ -108,7 +108,7 @@
'third_party/markupsafe',
'third_party/glslang/src',
'third_party/google_benchmark/src',
- 'third_party/googletest',
+ 'third_party/googletest/src',
'third_party/spirv-headers/src',
'third_party/spirv-tools/src',
'third_party/vulkan-headers/src',
