commit 50260413ccb217e376a11a4e647ce1085209bf03
author dan sinclair <dsinclair@chromium.org> Wed Aug 28 19:43:27 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 28 19:43:27 2024 +0000
tree c6684bef7051475ae9f801bd6689aac8e3fe9fba
parent aa14c8e8704d01c8e5c03e3b6e4839c29e908103

[spirv][ir] Add memory model annotations to Load/Store

This CL adds the Vulkan Memory Model `NonPrivatePointer` annotation to
the loads and stores.

Bug: 348702031
Change-Id: I65f3ae32bcd58ce4f6f9201d8b363be9c686a797
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/203495
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>

test/tint/builtins/gen/literal/abs/005174.wgsl.expected.spvasm

diff --git a/test/tint/builtins/gen/literal/abs/005174.wgsl.expected.spvasm b/test/tint/builtins/gen/literal/abs/005174.wgsl.expected.spvasm
index 937eff5..4bbef56 100644
--- a/test/tint/builtins/gen/literal/abs/005174.wgsl.expected.spvasm
+++ b/test/tint/builtins/gen/literal/abs/005174.wgsl.expected.spvasm
@@ -68,41 +68,41 @@
          %15 = OpLabel
         %res = OpVariable %_ptr_Function_v3float Function
                OpStore %res %18
-         %20 = OpLoad %v3float %res
+         %20 = OpLoad %v3float %res None
                OpReturnValue %20
                OpFunctionEnd
 %fragment_main = OpFunction %void None %23
          %24 = OpLabel
          %25 = OpFunctionCall %v3float %abs_005174
          %26 = OpAccessChain %_ptr_StorageBuffer_v3float %1 %uint_0
-               OpStore %26 %25
+               OpStore %26 %25 None
                OpReturn
                OpFunctionEnd
 %compute_main = OpFunction %void None %23
          %31 = OpLabel
          %32 = OpFunctionCall %v3float %abs_005174
          %33 = OpAccessChain %_ptr_StorageBuffer_v3float %1 %uint_0
-               OpStore %33 %32
+               OpStore %33 %32 None
                OpReturn
                OpFunctionEnd
 %vertex_main_inner = OpFunction %VertexOutput None %36
          %37 = OpLabel
         %out = OpVariable %_ptr_Function_VertexOutput Function %40
          %41 = OpAccessChain %_ptr_Function_v4float %out %uint_0
-               OpStore %41 %43
+               OpStore %41 %43 None
          %44 = OpAccessChain %_ptr_Function_v3float %out %uint_1
          %46 = OpFunctionCall %v3float %abs_005174
-               OpStore %44 %46
-         %47 = OpLoad %VertexOutput %out
+               OpStore %44 %46 None
+         %47 = OpLoad %VertexOutput %out None
                OpReturnValue %47
                OpFunctionEnd
 %vertex_main = OpFunction %void None %23
          %49 = OpLabel
          %50 = OpFunctionCall %VertexOutput %vertex_main_inner
          %51 = OpCompositeExtract %v4float %50 0
-               OpStore %vertex_main_position_Output %51
+               OpStore %vertex_main_position_Output %51 None
          %52 = OpCompositeExtract %v3float %50 1
-               OpStore %vertex_main_loc0_Output %52
-               OpStore %vertex_main___point_size_Output %float_1
+               OpStore %vertex_main_loc0_Output %52 None
+               OpStore %vertex_main___point_size_Output %float_1 None
                OpReturn
                OpFunctionEnd