commit 5029e70b6e7fdde6508b173f7fd80107100b6bcf
author Ben Clayton <bclayton@google.com> Fri Oct 15 14:17:31 2021 +0000
committer Tint LUCI CQ <tint-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 15 14:17:31 2021 +0000
tree 7514db12bf671b4ff9a3caf778abb46c7e4a0002
parent 4dfa394a3c22c50929a9351df78317eec215fa9d

ast: Remove helpers from ast::Type

These are legacy methods that were written before the semantic type nodes.

These methods do not consider aliases, and any use of these is likely to be broken for aliases.

Fix up uses of these methods to use the semantic types instead.

Change-Id: Ia66749b279eddff655d3d755fef54a6263643e69
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/66601
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>

src/transform/module_scope_var_to_entry_point_param.cc

diff --git a/src/transform/module_scope_var_to_entry_point_param.cc b/src/transform/module_scope_var_to_entry_point_param.cc
index c70d7fd..f0a3ee7f 100644
--- a/src/transform/module_scope_var_to_entry_point_param.cc
+++ b/src/transform/module_scope_var_to_entry_point_param.cc
@@ -228,7 +228,7 @@
           // Use a pointer for non-handle types.
           auto* param_type = store_type();
           ast::DecorationList attributes;
-          if (!param_type->is_handle()) {
+          if (!var->Type()->UnwrapRef()->is_handle()) {
             param_type = ctx.dst->ty.pointer(param_type, var->StorageClass());
             is_pointer = true;