commit 50b8d9cadea748172e0b0d01ab18882c66f5dd0d
author Shrek Shao <shrekshao@google.com> Mon Oct 16 20:38:40 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 16 20:38:40 2023 +0000
tree 806f80f29ae05fcb6047eae63cee826abc949a71
parent d2eb05cdd56d40a0cc21a8a5efa61a968eaeec10

Enable OpenGL backend shader robustness

Bug: dawn:1686, dawn:2124, tint:2060
Change-Id: I6f85ed97b4d262731ca1aa7852200d0fee962341
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/155992
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>

src/dawn/native/opengl/ShaderModuleGL.cpp

diff --git a/src/dawn/native/opengl/ShaderModuleGL.cpp b/src/dawn/native/opengl/ShaderModuleGL.cpp
index e96eeba..aa668f4 100644
--- a/src/dawn/native/opengl/ShaderModuleGL.cpp
+++ b/src/dawn/native/opengl/ShaderModuleGL.cpp
@@ -271,8 +271,7 @@
             tintOptions.version = tint::glsl::writer::Version(ToTintGLStandard(r.glVersionStandard),
                                                               r.glVersionMajor, r.glVersionMinor);
 
-            // TODO(crbug.com/dawn/1686): Robustness causes shader compilation failures.
-            tintOptions.disable_robustness = true;
+            tintOptions.disable_robustness = false;
 
             tintOptions.external_texture_options = r.externalTextureOptions;
 

src/dawn/tests/end2end/StorageTextureTests.cpp

diff --git a/src/dawn/tests/end2end/StorageTextureTests.cpp b/src/dawn/tests/end2end/StorageTextureTests.cpp
index 60607b2..434a67a 100644
--- a/src/dawn/tests/end2end/StorageTextureTests.cpp
+++ b/src/dawn/tests/end2end/StorageTextureTests.cpp
@@ -771,6 +771,9 @@
 
 // Verify 1D write-only storage textures work correctly.
 TEST_P(StorageTextureTests, Writeonly1DStorageTexture) {
+    // TODO(crbug.com/tint/2060): shader compile error for glsl writer.
+    DAWN_TEST_UNSUPPORTED_IF(IsOpenGL() || IsOpenGLES());
+
     constexpr wgpu::TextureFormat kTextureFormat = wgpu::TextureFormat::R32Uint;
 
     // Prepare the write-only storage texture.