commit 50f995851d9bc6f21373f00cf3a42f41b000283d
author Corentin Wallez <cwallez@chromium.org> Wed Mar 31 18:36:32 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Wed Mar 31 18:36:32 2021 +0000
tree f17773dc1e7051843bd0a6f7e5096c007e137f64
parent 7ef86335939609eca42065d058e11c755d28bd0f

DeviceBase: Make object creation use ResultOrError<Ref<T>>

This is in preparation for a change that will change all the
CreateFooInternal to be CreateFoo so they can be called in a
reentrant manner without special refcounting.

This also standardizes all the backends (except OpenGL and Null)
to use Object::Create that returns a Ref<T> or ResultOrError<Ref<T>>,
something we wanted to do for a long time.

Bug: dawn:723

Change-Id: I9e0baced333ffeb0affbc6a276c9bd9de082263a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46440
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

src/dawn_native/opengl/BindGroupGL.cpp

diff --git a/src/dawn_native/opengl/BindGroupGL.cpp b/src/dawn_native/opengl/BindGroupGL.cpp
index 486eb2c..721189b 100644
--- a/src/dawn_native/opengl/BindGroupGL.cpp
+++ b/src/dawn_native/opengl/BindGroupGL.cpp
@@ -54,7 +54,7 @@
     }
 
     // static
-    BindGroup* BindGroup::Create(Device* device, const BindGroupDescriptor* descriptor) {
+    Ref<BindGroup> BindGroup::Create(Device* device, const BindGroupDescriptor* descriptor) {
         return ToBackend(descriptor->layout)->AllocateBindGroup(device, descriptor);
     }