commit 572eaf271e6940ab4dbc9c98cad2d6cbcd3572ae
author Ben Clayton <bclayton@google.com> Fri May 27 20:22:26 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri May 27 20:22:26 2022 +0000
tree be3189e26d974571718b7f6f20653350903b8300
parent 4b04721075ca97a6118a50a398641d8c84e95bbf

tint: Remove ConversionFailure::kTooSmall

Nothing errors on this. Simplifies code.
Also: Disable MSVC warnings about constant overflow.

Fixed: tint:1564
Change-Id: I5bb2c2ebb89966f5b3f7cbcd73672e110b1b98cd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91622
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/tint/utils/compiler_macros.h

diff --git a/src/tint/utils/compiler_macros.h b/src/tint/utils/compiler_macros.h
index 8b360ff..ada138e 100644
--- a/src/tint/utils/compiler_macros.h
+++ b/src/tint/utils/compiler_macros.h
@@ -12,27 +12,30 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#include "src/tint/utils/concat.h"
+
 #ifndef SRC_TINT_UTILS_COMPILER_MACROS_H_
 #define SRC_TINT_UTILS_COMPILER_MACROS_H_
 
-#define TINT_REQUIRE_SEMICOLON \
-    do {                       \
-    } while (false)
+#define TINT_REQUIRE_SEMICOLON static_assert(true)
 
 #if defined(_MSC_VER)
+#define TINT_WARNING_UNREACHABLE_CODE 4702
+#define TINT_WARNING_CONSTANT_OVERFLOW 4756
+
 // clang-format off
-#define TINT_BEGIN_DISABLE_WARNING_UNREACHABLE_CODE() \
-    __pragma(warning(push))                           \
-    __pragma(warning(disable:4702))                   \
+#define TINT_BEGIN_DISABLE_WARNING(name)                        \
+    __pragma(warning(push))                                     \
+    __pragma(warning(disable:TINT_CONCAT(TINT_WARNING_, name))) \
     TINT_REQUIRE_SEMICOLON
-#define TINT_END_DISABLE_WARNING_UNREACHABLE_CODE()   \
-    __pragma(warning(pop))                            \
+#define TINT_END_DISABLE_WARNING(name)                          \
+    __pragma(warning(pop))                                      \
     TINT_REQUIRE_SEMICOLON
 // clang-format on
 #else
 // clang-format off
-#define TINT_BEGIN_DISABLE_WARNING_UNREACHABLE_CODE() TINT_REQUIRE_SEMICOLON
-#define TINT_END_DISABLE_WARNING_UNREACHABLE_CODE() TINT_REQUIRE_SEMICOLON
+#define TINT_BEGIN_DISABLE_WARNING(name) TINT_REQUIRE_SEMICOLON
+#define TINT_END_DISABLE_WARNING(name) TINT_REQUIRE_SEMICOLON
 // clang-format on
 #endif  // defined(_MSC_VER)