commit 5ad1adc9ffa4f91efb96b5269d41722b1eb3fb6b
author Jiawei Shao <jiawei.shao@intel.com> Fri Jun 02 00:31:16 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 02 00:31:16 2023 +0000
tree 69d7473568d3240d372cd7a0a691024f3b4eeee4
parent 0958c626d4067957c6b50d78962d812a1b758b33

Remove ASSERT that requires compilation message to be ASCII

This patch removes ASSERT that requires compilation message to be
ASCII in OwnedCompilationMessages::AddMessage(). In chromium this
function will only be called internally, so we can safely remove
the ASSERT expression to fix the libfuzzer test on
APICreateErrorShaderModule().

Fixed: chromium:1449501
Bug: dawn:1345
Test: dawn_unittests
Change-Id: Ie7eda6310726716d3bf4962a40a59bb7b99d5e63
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/135042
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>

src/dawn/native/CompilationMessages.cpp

diff --git a/src/dawn/native/CompilationMessages.cpp b/src/dawn/native/CompilationMessages.cpp
index 4dfa257..88e2570 100644
--- a/src/dawn/native/CompilationMessages.cpp
+++ b/src/dawn/native/CompilationMessages.cpp
@@ -86,9 +86,6 @@
     // Cannot add messages after GetCompilationInfo has been called.
     ASSERT(mCompilationInfo.messages == nullptr);
 
-    // Message can only contain ascii characters.
-    ASSERT(tint::utils::utf8::IsASCII(message));
-
     mMessageStrings.push_back(message);
     mMessages.push_back({nullptr, nullptr, static_cast<WGPUCompilationMessageType>(type), lineNum,
                          linePos, offset, length, linePos, offset, length});