commit 6366a019db85a5588b97e5867d9c43ba71c9d09f
author Austin Eng <enga@google.com> Thu Aug 03 16:14:30 2017 -0400
committer Austin Eng <213reeses@gmail.com> Mon Aug 07 18:51:48 2017 -0400
tree 37f2418f0bc67acfa395a1ee5ad3503f3b8ff1e9
parent 3a8f48504dcee021729aac0d79bab25b3ab84091

Validate render subpass for SetBlendColor and SetStencilReference

src/backend/CommandBuffer.cpp

diff --git a/src/backend/CommandBuffer.cpp b/src/backend/CommandBuffer.cpp
index 5159c2f..011daf1 100644
--- a/src/backend/CommandBuffer.cpp
+++ b/src/backend/CommandBuffer.cpp
@@ -573,8 +573,8 @@
                 case Command::SetStencilReference:
                     {
                         iterator.NextCommand<SetStencilReferenceCmd>();
-                        if (!state->HaveRenderPass()) {
-                            HandleError("Can't set stencil reference without an active render pass");
+                        if (!state->HaveRenderSubpass()) {
+                            HandleError("Can't set stencil reference without an active render subpass");
                             return false;
                         }
                     }
@@ -583,8 +583,8 @@
                 case Command::SetBlendColor:
                     {
                         iterator.NextCommand<SetBlendColorCmd>();
-                        if (!state->HaveRenderPass()) {
-                            HandleError("Can't set blend color without an active render pass");
+                        if (!state->HaveRenderSubpass()) {
+                            HandleError("Can't set blend color without an active render subpass");
                             return false;
                         }
                     }

src/backend/CommandBufferStateTracker.cpp

diff --git a/src/backend/CommandBufferStateTracker.cpp b/src/backend/CommandBufferStateTracker.cpp
index 51087fc..e0bc4c6 100644
--- a/src/backend/CommandBufferStateTracker.cpp
+++ b/src/backend/CommandBufferStateTracker.cpp
@@ -37,6 +37,10 @@
         return currentRenderPass != nullptr;
     }
 
+    bool CommandBufferStateTracker::HaveRenderSubpass() const {
+        return aspects[VALIDATION_ASPECT_RENDER_SUBPASS];
+    }
+
     bool CommandBufferStateTracker::ValidateCanCopy() const {
         if (currentRenderPass) {
             builder->HandleError("Copy cannot occur during a render pass");

src/backend/CommandBufferStateTracker.h

diff --git a/src/backend/CommandBufferStateTracker.h b/src/backend/CommandBufferStateTracker.h
index aaa26ad..43edbb8 100644
--- a/src/backend/CommandBufferStateTracker.h
+++ b/src/backend/CommandBufferStateTracker.h
@@ -30,6 +30,7 @@
 
             // Non-state-modifying validation functions
             bool HaveRenderPass() const;
+            bool HaveRenderSubpass() const;
             bool ValidateCanCopy() const;
             bool ValidateCanUseBufferAs(BufferBase* buffer, nxt::BufferUsageBit usage) const;
             bool ValidateCanUseTextureAs(TextureBase* texture, nxt::TextureUsageBit usage) const;