commit 6661b28d1e0fa7654c51037dc4e1137df13b8e55
author Brandon Jones <brandon1.jones@intel.com> Fri Feb 25 20:14:52 2022 +0000
committer Tint LUCI CQ <tint-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Feb 25 20:14:52 2022 +0000
tree 1c2116571a768cd3cf6e36cb8d63aa739bb46bda
parent dbf75bc217937c171177bce176c3965a191aa14e

Delete Single-Plane External Texture Transform

The multiplanar external texture transform has been integrated into
Dawn, which means we have no use for the single plane transform - so it
should be deleted.

Bug: dawn:1082
Change-Id: Id8977d03839b76c90ae6e70400d048c13fbe85f4
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80120
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Brandon1 Jones <brandon1.jones@intel.com>

src/tint/writer/hlsl/generator_impl.cc

diff --git a/src/tint/writer/hlsl/generator_impl.cc b/src/tint/writer/hlsl/generator_impl.cc
index 79664ae..0ddd070 100644
--- a/src/tint/writer/hlsl/generator_impl.cc
+++ b/src/tint/writer/hlsl/generator_impl.cc
@@ -52,7 +52,6 @@
 #include "src/tint/transform/calculate_array_length.h"
 #include "src/tint/transform/canonicalize_entry_point_io.h"
 #include "src/tint/transform/decompose_memory_access.h"
-#include "src/tint/transform/external_texture_transform.h"
 #include "src/tint/transform/fold_trivial_single_use_lets.h"
 #include "src/tint/transform/localize_struct_array_assignment.h"
 #include "src/tint/transform/loop_to_for_loop.h"
@@ -206,7 +205,6 @@
   // DecomposeMemoryAccess special-cases the arrayLength() intrinsic, which
   // will be transformed by CalculateArrayLength
   manager.Add<transform::CalculateArrayLength>();
-  manager.Add<transform::ExternalTextureTransform>();
   manager.Add<transform::PromoteInitializersToConstVar>();
 
   manager.Add<transform::PadArrayElements>();
@@ -3645,6 +3643,12 @@
         return true;
       },
       [&](const sem::Texture* tex) {
+        if (tex->Is<sem::ExternalTexture>()) {
+          TINT_ICE(Writer, diagnostics_)
+              << "Multiplanar external texture transform was not run.";
+          return false;
+        }
+
         auto* storage = tex->As<sem::StorageTexture>();
         auto* ms = tex->As<sem::MultisampledTexture>();
         auto* depth_ms = tex->As<sem::DepthMultisampledTexture>();