[ir] Update transform names when validating.
This Cl updates the names used in validating the IR to always prefix
with the language name. This makes it clearer when both core and
language specific transforms with the same name execute which one you're
looking at.
Change-Id: I9c45126f3104a3bb26f88ca4b2bc84c4577c7cd3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/212574
Auto-Submit: dan sinclair <dsinclair@chromium.org>
Commit-Queue: James Price <jrprice@google.com>
Reviewed-by: James Price <jrprice@google.com>
diff --git a/src/tint/lang/core/ir/transform/add_empty_entry_point.cc b/src/tint/lang/core/ir/transform/add_empty_entry_point.cc
index bb91224..15107c3 100644
--- a/src/tint/lang/core/ir/transform/add_empty_entry_point.cc
+++ b/src/tint/lang/core/ir/transform/add_empty_entry_point.cc
@@ -54,7 +54,7 @@
Result<SuccessType> AddEmptyEntryPoint(Module& ir) {
auto result = ValidateAndDumpIfNeeded(
- ir, "AddEmptyEntryPoint transform",
+ ir, "core.AddEmptyEntryPoint",
core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings});
if (result != Success) {
return result.Failure();
diff --git a/src/tint/lang/core/ir/transform/array_length_from_uniform.cc b/src/tint/lang/core/ir/transform/array_length_from_uniform.cc
index 0dd01ea..63f4cb7 100644
--- a/src/tint/lang/core/ir/transform/array_length_from_uniform.cc
+++ b/src/tint/lang/core/ir/transform/array_length_from_uniform.cc
@@ -235,7 +235,7 @@
Module& ir,
BindingPoint ubo_binding,
const std::unordered_map<BindingPoint, uint32_t>& bindpoint_to_size_index) {
- auto validated = ValidateAndDumpIfNeeded(ir, "ArrayLengthFromUniform transform");
+ auto validated = ValidateAndDumpIfNeeded(ir, "core.ArrayLengthFromUniform");
if (validated != Success) {
return validated.Failure();
}
diff --git a/src/tint/lang/core/ir/transform/bgra8unorm_polyfill.cc b/src/tint/lang/core/ir/transform/bgra8unorm_polyfill.cc
index 8d1fd84..468c008 100644
--- a/src/tint/lang/core/ir/transform/bgra8unorm_polyfill.cc
+++ b/src/tint/lang/core/ir/transform/bgra8unorm_polyfill.cc
@@ -182,7 +182,7 @@
} // namespace
Result<SuccessType> Bgra8UnormPolyfill(Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "Bgra8UnormPolyfill transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.Bgra8UnormPolyfill");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/core/ir/transform/binary_polyfill.cc b/src/tint/lang/core/ir/transform/binary_polyfill.cc
index f609f28..4a2da27 100644
--- a/src/tint/lang/core/ir/transform/binary_polyfill.cc
+++ b/src/tint/lang/core/ir/transform/binary_polyfill.cc
@@ -201,7 +201,7 @@
} // namespace
Result<SuccessType> BinaryPolyfill(Module& ir, const BinaryPolyfillConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "BinaryPolyfill transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.BinaryPolyfill");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/core/ir/transform/binding_remapper.cc b/src/tint/lang/core/ir/transform/binding_remapper.cc
index 47d65ff..efa1e14 100644
--- a/src/tint/lang/core/ir/transform/binding_remapper.cc
+++ b/src/tint/lang/core/ir/transform/binding_remapper.cc
@@ -77,7 +77,7 @@
Result<SuccessType> BindingRemapper(
Module& ir,
const std::unordered_map<BindingPoint, BindingPoint>& binding_points) {
- auto result = ValidateAndDumpIfNeeded(ir, "BindingRemapper transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.BindingRemapper");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/core/ir/transform/block_decorated_structs.cc b/src/tint/lang/core/ir/transform/block_decorated_structs.cc
index 8478f35..b565a7c 100644
--- a/src/tint/lang/core/ir/transform/block_decorated_structs.cc
+++ b/src/tint/lang/core/ir/transform/block_decorated_structs.cc
@@ -120,7 +120,7 @@
} // namespace
Result<SuccessType> BlockDecoratedStructs(Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "BlockDecoratedStructs transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.BlockDecoratedStructs");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/core/ir/transform/builtin_polyfill.cc b/src/tint/lang/core/ir/transform/builtin_polyfill.cc
index 789cd71..b668f2e 100644
--- a/src/tint/lang/core/ir/transform/builtin_polyfill.cc
+++ b/src/tint/lang/core/ir/transform/builtin_polyfill.cc
@@ -930,7 +930,7 @@
} // namespace
Result<SuccessType> BuiltinPolyfill(Module& ir, const BuiltinPolyfillConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.BuiltinPolyfill");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/core/ir/transform/combine_access_instructions.cc b/src/tint/lang/core/ir/transform/combine_access_instructions.cc
index 08a91f4..a65d04d 100644
--- a/src/tint/lang/core/ir/transform/combine_access_instructions.cc
+++ b/src/tint/lang/core/ir/transform/combine_access_instructions.cc
@@ -80,7 +80,7 @@
} // namespace
Result<SuccessType> CombineAccessInstructions(Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "CombineAccessInstructions transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.CombineAccessInstructions");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/core/ir/transform/conversion_polyfill.cc b/src/tint/lang/core/ir/transform/conversion_polyfill.cc
index f4db087..becfdf9 100644
--- a/src/tint/lang/core/ir/transform/conversion_polyfill.cc
+++ b/src/tint/lang/core/ir/transform/conversion_polyfill.cc
@@ -189,7 +189,7 @@
} // namespace
Result<SuccessType> ConversionPolyfill(Module& ir, const ConversionPolyfillConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "ConversionPolyfill transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.ConversionPolyfill");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/core/ir/transform/demote_to_helper.cc b/src/tint/lang/core/ir/transform/demote_to_helper.cc
index 4c2ad12..ceb6f8f 100644
--- a/src/tint/lang/core/ir/transform/demote_to_helper.cc
+++ b/src/tint/lang/core/ir/transform/demote_to_helper.cc
@@ -214,7 +214,7 @@
} // namespace
Result<SuccessType> DemoteToHelper(Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "DemoteToHelper transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "core.DemoteToHelper",
core::ir::Capabilities{
core::ir::Capability::kAllowVectorElementPointer,
core::ir::Capability::kAllowClipDistancesOnF32,
diff --git a/src/tint/lang/core/ir/transform/direct_variable_access.cc b/src/tint/lang/core/ir/transform/direct_variable_access.cc
index 85ace98..67686ea 100644
--- a/src/tint/lang/core/ir/transform/direct_variable_access.cc
+++ b/src/tint/lang/core/ir/transform/direct_variable_access.cc
@@ -704,7 +704,7 @@
} // namespace
Result<SuccessType> DirectVariableAccess(Module& ir, const DirectVariableAccessOptions& options) {
- auto result = ValidateAndDumpIfNeeded(ir, "DirectVariableAccess transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "core.DirectVariableAccess",
core::ir::Capabilities{
core::ir::Capability::kAllowClipDistancesOnF32,
});
diff --git a/src/tint/lang/core/ir/transform/multiplanar_external_texture.cc b/src/tint/lang/core/ir/transform/multiplanar_external_texture.cc
index 68793ea..9ad597e 100644
--- a/src/tint/lang/core/ir/transform/multiplanar_external_texture.cc
+++ b/src/tint/lang/core/ir/transform/multiplanar_external_texture.cc
@@ -610,7 +610,7 @@
Result<SuccessType> MultiplanarExternalTexture(
Module& ir,
const tint::transform::multiplanar::BindingsMap& multiplanar_map) {
- auto result = ValidateAndDumpIfNeeded(ir, "MultiplanarExternalTexture transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.MultiplanarExternalTexture");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/core/ir/transform/prepare_push_constants.cc b/src/tint/lang/core/ir/transform/prepare_push_constants.cc
index d32f4b0..b3f64b5 100644
--- a/src/tint/lang/core/ir/transform/prepare_push_constants.cc
+++ b/src/tint/lang/core/ir/transform/prepare_push_constants.cc
@@ -129,7 +129,7 @@
Result<PushConstantLayout> PreparePushConstants(Module& ir,
const PreparePushConstantsConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "PreparePushConstants transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.PreparePushConstants");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/core/ir/transform/preserve_padding.cc b/src/tint/lang/core/ir/transform/preserve_padding.cc
index 9ffb4a9..463ebfa 100644
--- a/src/tint/lang/core/ir/transform/preserve_padding.cc
+++ b/src/tint/lang/core/ir/transform/preserve_padding.cc
@@ -174,7 +174,7 @@
Result<SuccessType> PreservePadding(Module& ir) {
auto result = ValidateAndDumpIfNeeded(
- ir, "PreservePadding transform",
+ ir, "core.PreservePadding",
core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings});
if (result != Success) {
return result;
diff --git a/src/tint/lang/core/ir/transform/remove_continue_in_switch.cc b/src/tint/lang/core/ir/transform/remove_continue_in_switch.cc
index 3e7daff..997a9e1 100644
--- a/src/tint/lang/core/ir/transform/remove_continue_in_switch.cc
+++ b/src/tint/lang/core/ir/transform/remove_continue_in_switch.cc
@@ -114,7 +114,7 @@
} // namespace
Result<SuccessType> RemoveContinueInSwitch(Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "RemoveContinueInSwitch transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "core.RemoveContinueInSwitch",
core::ir::Capabilities{
core::ir::Capability::kAllowVectorElementPointer,
core::ir::Capability::kAllowHandleVarsWithoutBindings,
diff --git a/src/tint/lang/core/ir/transform/remove_terminator_args.cc b/src/tint/lang/core/ir/transform/remove_terminator_args.cc
index 9528622..7feb71d 100644
--- a/src/tint/lang/core/ir/transform/remove_terminator_args.cc
+++ b/src/tint/lang/core/ir/transform/remove_terminator_args.cc
@@ -164,7 +164,7 @@
} // namespace
Result<SuccessType> RemoveTerminatorArgs(Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "RemoveTerminatorArgs transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "core.RemoveTerminatorArgs",
core::ir::Capabilities{
core::ir::Capability::kAllow8BitIntegers,
core::ir::Capability::kAllowPointersInStructures,
diff --git a/src/tint/lang/core/ir/transform/rename_conflicts.cc b/src/tint/lang/core/ir/transform/rename_conflicts.cc
index 1c168ca..d79ad9d 100644
--- a/src/tint/lang/core/ir/transform/rename_conflicts.cc
+++ b/src/tint/lang/core/ir/transform/rename_conflicts.cc
@@ -293,7 +293,7 @@
} // namespace
Result<SuccessType> RenameConflicts(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "RenameConflicts transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "core.RenameConflicts",
core::ir::Capabilities{
core::ir::Capability::kAllow8BitIntegers,
core::ir::Capability::kAllowPointersInStructures,
diff --git a/src/tint/lang/core/ir/transform/robustness.cc b/src/tint/lang/core/ir/transform/robustness.cc
index fa20c4f..079a6cd 100644
--- a/src/tint/lang/core/ir/transform/robustness.cc
+++ b/src/tint/lang/core/ir/transform/robustness.cc
@@ -381,7 +381,7 @@
} // namespace
Result<SuccessType> Robustness(Module& ir, const RobustnessConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "Robustness transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.Robustness");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/core/ir/transform/single_entry_point.cc b/src/tint/lang/core/ir/transform/single_entry_point.cc
index 2282813..fac0814 100644
--- a/src/tint/lang/core/ir/transform/single_entry_point.cc
+++ b/src/tint/lang/core/ir/transform/single_entry_point.cc
@@ -91,7 +91,7 @@
} // namespace
Result<SuccessType> SingleEntryPoint(Module& ir, std::string_view entry_point_name) {
- auto result = ValidateAndDumpIfNeeded(ir, "SingleEntryPoint transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.SingleEntryPoint");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/core/ir/transform/std140.cc b/src/tint/lang/core/ir/transform/std140.cc
index 7b206da..c799741 100644
--- a/src/tint/lang/core/ir/transform/std140.cc
+++ b/src/tint/lang/core/ir/transform/std140.cc
@@ -451,7 +451,7 @@
Result<SuccessType> Std140(Module& ir) {
auto result = ValidateAndDumpIfNeeded(
- ir, "Std140 transform",
+ ir, "core.Std140",
core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings});
if (result != Success) {
return result;
diff --git a/src/tint/lang/core/ir/transform/value_to_let.cc b/src/tint/lang/core/ir/transform/value_to_let.cc
index 457ca79..3794625 100644
--- a/src/tint/lang/core/ir/transform/value_to_let.cc
+++ b/src/tint/lang/core/ir/transform/value_to_let.cc
@@ -257,7 +257,7 @@
} // namespace
Result<SuccessType> ValueToLet(Module& ir, const ValueToLetConfig& cfg) {
- auto result = ValidateAndDumpIfNeeded(ir, "ValueToLet transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "core.ValueToLet",
core::ir::Capabilities{
core::ir::Capability::kAllow8BitIntegers,
core::ir::Capability::kAllowPointersInStructures,
diff --git a/src/tint/lang/core/ir/transform/vectorize_scalar_matrix_constructors.cc b/src/tint/lang/core/ir/transform/vectorize_scalar_matrix_constructors.cc
index 57eebab..ec96c26 100644
--- a/src/tint/lang/core/ir/transform/vectorize_scalar_matrix_constructors.cc
+++ b/src/tint/lang/core/ir/transform/vectorize_scalar_matrix_constructors.cc
@@ -94,7 +94,7 @@
} // namespace
Result<SuccessType> VectorizeScalarMatrixConstructors(Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "VectorizeScalarMatrixConstructors transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "core.VectorizeScalarMatrixConstructors",
core::ir::Capabilities{
core::ir::Capability::kAllowVectorElementPointer,
core::ir::Capability::kAllowHandleVarsWithoutBindings,
diff --git a/src/tint/lang/core/ir/transform/zero_init_workgroup_memory.cc b/src/tint/lang/core/ir/transform/zero_init_workgroup_memory.cc
index 9566183..4a5424b 100644
--- a/src/tint/lang/core/ir/transform/zero_init_workgroup_memory.cc
+++ b/src/tint/lang/core/ir/transform/zero_init_workgroup_memory.cc
@@ -305,7 +305,7 @@
} // namespace
Result<SuccessType> ZeroInitWorkgroupMemory(Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "ZeroInitWorkgroupMemory transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "core.ZeroInitWorkgroupMemory");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/glsl/writer/printer/printer.cc b/src/tint/lang/glsl/writer/printer/printer.cc
index 0afcb89..b79f522 100644
--- a/src/tint/lang/glsl/writer/printer/printer.cc
+++ b/src/tint/lang/glsl/writer/printer/printer.cc
@@ -117,7 +117,7 @@
/// @returns the generated GLSL shader
tint::Result<std::string> Generate() {
auto valid = core::ir::ValidateAndDumpIfNeeded(
- ir_, "GLSL writer",
+ ir_, "glsl.Printer",
core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings});
if (valid != Success) {
return std::move(valid.Failure());
diff --git a/src/tint/lang/glsl/writer/raise/binary_polyfill.cc b/src/tint/lang/glsl/writer/raise/binary_polyfill.cc
index b538f1a..7a295c2 100644
--- a/src/tint/lang/glsl/writer/raise/binary_polyfill.cc
+++ b/src/tint/lang/glsl/writer/raise/binary_polyfill.cc
@@ -216,7 +216,7 @@
} // namespace
Result<SuccessType> BinaryPolyfill(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "glsl.BinaryPolyfill transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "glsl.BinaryPolyfill");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/glsl/writer/raise/bitcast_polyfill.cc b/src/tint/lang/glsl/writer/raise/bitcast_polyfill.cc
index 476c9a9..d8560af 100644
--- a/src/tint/lang/glsl/writer/raise/bitcast_polyfill.cc
+++ b/src/tint/lang/glsl/writer/raise/bitcast_polyfill.cc
@@ -279,7 +279,7 @@
Result<SuccessType> BitcastPolyfill(core::ir::Module& ir) {
auto result = ValidateAndDumpIfNeeded(
- ir, "glsl::BitcastPolyfill transform",
+ ir, "glsl.BitcastPolyfill",
core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings});
if (result != Success) {
return result.Failure();
diff --git a/src/tint/lang/glsl/writer/raise/builtin_polyfill.cc b/src/tint/lang/glsl/writer/raise/builtin_polyfill.cc
index 1711137..b82c366 100644
--- a/src/tint/lang/glsl/writer/raise/builtin_polyfill.cc
+++ b/src/tint/lang/glsl/writer/raise/builtin_polyfill.cc
@@ -527,7 +527,7 @@
} // namespace
Result<SuccessType> BuiltinPolyfill(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "glsl.BuiltinPolyfill");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/glsl/writer/raise/offset_first_index.cc b/src/tint/lang/glsl/writer/raise/offset_first_index.cc
index dd431ad..3ef806f 100644
--- a/src/tint/lang/glsl/writer/raise/offset_first_index.cc
+++ b/src/tint/lang/glsl/writer/raise/offset_first_index.cc
@@ -110,7 +110,7 @@
} // namespace
Result<SuccessType> OffsetFirstIndex(core::ir::Module& ir, const OffsetFirstIndexConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "glsl.OffsetFirstIndex transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "glsl.OffsetFirstIndex",
core::ir::Capabilities{
core::ir::Capability::kAllowHandleVarsWithoutBindings,
});
diff --git a/src/tint/lang/glsl/writer/raise/shader_io.cc b/src/tint/lang/glsl/writer/raise/shader_io.cc
index 2e6054c..95e4f4c 100644
--- a/src/tint/lang/glsl/writer/raise/shader_io.cc
+++ b/src/tint/lang/glsl/writer/raise/shader_io.cc
@@ -263,7 +263,7 @@
Result<SuccessType> ShaderIO(core::ir::Module& ir, const ShaderIOConfig& config) {
auto result = ValidateAndDumpIfNeeded(
- ir, "ShaderIO transform",
+ ir, "gls.lShaderIO",
core::ir::Capabilities{core::ir::Capability::kAllowHandleVarsWithoutBindings});
if (result != Success) {
return result;
diff --git a/src/tint/lang/glsl/writer/raise/texture_builtins_from_uniform.cc b/src/tint/lang/glsl/writer/raise/texture_builtins_from_uniform.cc
index 48e144e..3db84fd 100644
--- a/src/tint/lang/glsl/writer/raise/texture_builtins_from_uniform.cc
+++ b/src/tint/lang/glsl/writer/raise/texture_builtins_from_uniform.cc
@@ -217,7 +217,7 @@
Result<SuccessType> TextureBuiltinsFromUniform(core::ir::Module& ir,
const TextureBuiltinsFromUniformOptions& cfg) {
- auto result = ValidateAndDumpIfNeeded(ir, "glsl.TextureBuiltinsFromUniform transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "glsl.TextureBuiltinsFromUniform");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/glsl/writer/raise/texture_polyfill.cc b/src/tint/lang/glsl/writer/raise/texture_polyfill.cc
index a7e9a51..6d1b55a 100644
--- a/src/tint/lang/glsl/writer/raise/texture_polyfill.cc
+++ b/src/tint/lang/glsl/writer/raise/texture_polyfill.cc
@@ -1217,7 +1217,7 @@
} // namespace
Result<SuccessType> TexturePolyfill(core::ir::Module& ir, const TexturePolyfillConfig& cfg) {
- auto result = ValidateAndDumpIfNeeded(ir, "glsl.TexturePolyfill transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "glsl.TexturePolyfill");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/hlsl/writer/printer/printer.cc b/src/tint/lang/hlsl/writer/printer/printer.cc
index 34ce4ea..89a9fff 100644
--- a/src/tint/lang/hlsl/writer/printer/printer.cc
+++ b/src/tint/lang/hlsl/writer/printer/printer.cc
@@ -160,7 +160,7 @@
core::ir::Capability::kAllowVectorElementPointer,
core::ir::Capability::kAllowClipDistancesOnF32,
};
- auto valid = core::ir::ValidateAndDumpIfNeeded(ir_, "HLSL writer", capabilities);
+ auto valid = core::ir::ValidateAndDumpIfNeeded(ir_, "hlsl.Printer", capabilities);
if (valid != Success) {
return std::move(valid.Failure());
}
diff --git a/src/tint/lang/hlsl/writer/raise/binary_polyfill.cc b/src/tint/lang/hlsl/writer/raise/binary_polyfill.cc
index e3f4587..93ffba6 100644
--- a/src/tint/lang/hlsl/writer/raise/binary_polyfill.cc
+++ b/src/tint/lang/hlsl/writer/raise/binary_polyfill.cc
@@ -136,7 +136,7 @@
} // namespace
Result<SuccessType> BinaryPolyfill(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "BinaryPolyfill transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.BinaryPolyfill",
core::ir::Capabilities{
core::ir::Capability::kAllowClipDistancesOnF32,
});
diff --git a/src/tint/lang/hlsl/writer/raise/builtin_polyfill.cc b/src/tint/lang/hlsl/writer/raise/builtin_polyfill.cc
index f1b5f36..222465f 100644
--- a/src/tint/lang/hlsl/writer/raise/builtin_polyfill.cc
+++ b/src/tint/lang/hlsl/writer/raise/builtin_polyfill.cc
@@ -1924,7 +1924,7 @@
} // namespace
Result<SuccessType> BuiltinPolyfill(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.BuiltinPolyfill",
core::ir::Capabilities{
core::ir::Capability::kAllowClipDistancesOnF32,
});
diff --git a/src/tint/lang/hlsl/writer/raise/decompose_storage_access.cc b/src/tint/lang/hlsl/writer/raise/decompose_storage_access.cc
index 288bb3c..a5deb31 100644
--- a/src/tint/lang/hlsl/writer/raise/decompose_storage_access.cc
+++ b/src/tint/lang/hlsl/writer/raise/decompose_storage_access.cc
@@ -898,7 +898,7 @@
} // namespace
Result<SuccessType> DecomposeStorageAccess(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "DecomposeStorageAccess transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.DecomposeStorageAccess",
core::ir::Capabilities{
core::ir::Capability::kAllowClipDistancesOnF32,
});
diff --git a/src/tint/lang/hlsl/writer/raise/decompose_uniform_access.cc b/src/tint/lang/hlsl/writer/raise/decompose_uniform_access.cc
index dd1d9a2..5d237f8 100644
--- a/src/tint/lang/hlsl/writer/raise/decompose_uniform_access.cc
+++ b/src/tint/lang/hlsl/writer/raise/decompose_uniform_access.cc
@@ -586,7 +586,7 @@
} // namespace
Result<SuccessType> DecomposeUniformAccess(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "DecomposeUniformAccess transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.DecomposeUniformAccess",
core::ir::Capabilities{
core::ir::Capability::kAllowClipDistancesOnF32,
});
diff --git a/src/tint/lang/hlsl/writer/raise/fxc_polyfill.cc b/src/tint/lang/hlsl/writer/raise/fxc_polyfill.cc
index 7369b40..1d332e2 100644
--- a/src/tint/lang/hlsl/writer/raise/fxc_polyfill.cc
+++ b/src/tint/lang/hlsl/writer/raise/fxc_polyfill.cc
@@ -75,7 +75,7 @@
} // namespace
Result<SuccessType> FxcPolyfill(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "FxcPolyfill transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.FxcPolyfill");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/hlsl/writer/raise/localize_struct_array_assignment.cc b/src/tint/lang/hlsl/writer/raise/localize_struct_array_assignment.cc
index 638d089..c5d08d7 100644
--- a/src/tint/lang/hlsl/writer/raise/localize_struct_array_assignment.cc
+++ b/src/tint/lang/hlsl/writer/raise/localize_struct_array_assignment.cc
@@ -158,7 +158,7 @@
} // namespace
Result<SuccessType> LocalizeStructArrayAssignment(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "LocalizeStructArrayAssignment transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.LocalizeStructArrayAssignment");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/hlsl/writer/raise/pixel_local.cc b/src/tint/lang/hlsl/writer/raise/pixel_local.cc
index 962258f..e6d8ab0 100644
--- a/src/tint/lang/hlsl/writer/raise/pixel_local.cc
+++ b/src/tint/lang/hlsl/writer/raise/pixel_local.cc
@@ -245,7 +245,7 @@
} // namespace
Result<SuccessType> PixelLocal(core::ir::Module& ir, const PixelLocalConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "PixelLocal transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.PixelLocal",
core::ir::Capabilities{
core::ir::Capability::kAllowClipDistancesOnF32,
});
diff --git a/src/tint/lang/hlsl/writer/raise/promote_initializers.cc b/src/tint/lang/hlsl/writer/raise/promote_initializers.cc
index 3d0bb78..e09b39f 100644
--- a/src/tint/lang/hlsl/writer/raise/promote_initializers.cc
+++ b/src/tint/lang/hlsl/writer/raise/promote_initializers.cc
@@ -238,7 +238,7 @@
} // namespace
Result<SuccessType> PromoteInitializers(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "PromoteInitializers transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.PromoteInitializers",
core::ir::Capabilities{
core::ir::Capability::kAllowVectorElementPointer,
core::ir::Capability::kAllowClipDistancesOnF32,
diff --git a/src/tint/lang/hlsl/writer/raise/replace_non_indexable_mat_vec_stores.cc b/src/tint/lang/hlsl/writer/raise/replace_non_indexable_mat_vec_stores.cc
index 1cf3f3f..8f06a50 100644
--- a/src/tint/lang/hlsl/writer/raise/replace_non_indexable_mat_vec_stores.cc
+++ b/src/tint/lang/hlsl/writer/raise/replace_non_indexable_mat_vec_stores.cc
@@ -287,7 +287,7 @@
} // namespace
Result<SuccessType> ReplaceNonIndexableMatVecStores(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "ReplaceNonIndexableMatVecStores transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.ReplaceNonIndexableMatVecStores");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/hlsl/writer/raise/shader_io.cc b/src/tint/lang/hlsl/writer/raise/shader_io.cc
index b19edf2..cf58e37 100644
--- a/src/tint/lang/hlsl/writer/raise/shader_io.cc
+++ b/src/tint/lang/hlsl/writer/raise/shader_io.cc
@@ -471,7 +471,7 @@
} // namespace
Result<SuccessType> ShaderIO(core::ir::Module& ir, const ShaderIOConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "ShaderIO transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "hlsl.ShaderIO");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/msl/writer/printer/printer.cc b/src/tint/lang/msl/writer/printer/printer.cc
index aa84321..9d2b0a1 100644
--- a/src/tint/lang/msl/writer/printer/printer.cc
+++ b/src/tint/lang/msl/writer/printer/printer.cc
@@ -118,7 +118,7 @@
/// @returns the generated MSL shader
tint::Result<PrintResult> Generate() {
auto valid =
- core::ir::ValidateAndDumpIfNeeded(ir_, "MSL writer",
+ core::ir::ValidateAndDumpIfNeeded(ir_, "msl.Printer",
core::ir::Capabilities{
core::ir::Capability::kAllow8BitIntegers,
core::ir::Capability::kAllowPointersInStructures,
diff --git a/src/tint/lang/msl/writer/raise/binary_polyfill.cc b/src/tint/lang/msl/writer/raise/binary_polyfill.cc
index 13e09e1..bdf4b07 100644
--- a/src/tint/lang/msl/writer/raise/binary_polyfill.cc
+++ b/src/tint/lang/msl/writer/raise/binary_polyfill.cc
@@ -157,7 +157,7 @@
} // namespace
Result<SuccessType> BinaryPolyfill(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "BinaryPolyfill transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "msl.BinaryPolyfill",
core::ir::Capabilities{
core::ir::Capability::kAllowPointersInStructures,
});
diff --git a/src/tint/lang/msl/writer/raise/builtin_polyfill.cc b/src/tint/lang/msl/writer/raise/builtin_polyfill.cc
index 185edd5..8f3983a 100644
--- a/src/tint/lang/msl/writer/raise/builtin_polyfill.cc
+++ b/src/tint/lang/msl/writer/raise/builtin_polyfill.cc
@@ -933,7 +933,7 @@
} // namespace
Result<SuccessType> BuiltinPolyfill(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "msl.BuiltinPolyfill",
core::ir::Capabilities{
core::ir::Capability::kAllowPointersInStructures,
});
diff --git a/src/tint/lang/msl/writer/raise/module_scope_vars.cc b/src/tint/lang/msl/writer/raise/module_scope_vars.cc
index 8727e39..a5cfadb 100644
--- a/src/tint/lang/msl/writer/raise/module_scope_vars.cc
+++ b/src/tint/lang/msl/writer/raise/module_scope_vars.cc
@@ -317,7 +317,7 @@
} // namespace
Result<SuccessType> ModuleScopeVars(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "ModuleScopeVars transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "msl.ModuleScopeVars");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/msl/writer/raise/packed_vec3.cc b/src/tint/lang/msl/writer/raise/packed_vec3.cc
index aa059e6..36c9fae 100644
--- a/src/tint/lang/msl/writer/raise/packed_vec3.cc
+++ b/src/tint/lang/msl/writer/raise/packed_vec3.cc
@@ -633,7 +633,7 @@
} // namespace
Result<SuccessType> PackedVec3(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "PackedVec3 transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "msl.PackedVec3");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/msl/writer/raise/shader_io.cc b/src/tint/lang/msl/writer/raise/shader_io.cc
index 018519c..caa6f08 100644
--- a/src/tint/lang/msl/writer/raise/shader_io.cc
+++ b/src/tint/lang/msl/writer/raise/shader_io.cc
@@ -244,7 +244,7 @@
} // namespace
Result<SuccessType> ShaderIO(core::ir::Module& ir, const ShaderIOConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "ShaderIO transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "msl.ShaderIO");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/msl/writer/raise/simd_ballot.cc b/src/tint/lang/msl/writer/raise/simd_ballot.cc
index 1b4c84c..5d95b5b 100644
--- a/src/tint/lang/msl/writer/raise/simd_ballot.cc
+++ b/src/tint/lang/msl/writer/raise/simd_ballot.cc
@@ -160,7 +160,7 @@
} // namespace
Result<SuccessType> SimdBallot(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "SimdBallot transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "msl.SimdBallot");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/msl/writer/raise/unary_polyfill.cc b/src/tint/lang/msl/writer/raise/unary_polyfill.cc
index 167dcb1..940f16a 100644
--- a/src/tint/lang/msl/writer/raise/unary_polyfill.cc
+++ b/src/tint/lang/msl/writer/raise/unary_polyfill.cc
@@ -88,7 +88,7 @@
} // namespace
Result<SuccessType> UnaryPolyfill(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "UnaryPolyfill transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "msl.UnaryPolyfill",
core::ir::Capabilities{
core::ir::Capability::kAllowPointersInStructures,
});
diff --git a/src/tint/lang/spirv/reader/lower/lower.cc b/src/tint/lang/spirv/reader/lower/lower.cc
index 433d0cd..f1861d4 100644
--- a/src/tint/lang/spirv/reader/lower/lower.cc
+++ b/src/tint/lang/spirv/reader/lower/lower.cc
@@ -45,8 +45,7 @@
RUN_TRANSFORM(lower::VectorElementPointer, mod);
RUN_TRANSFORM(lower::ShaderIO, mod);
- if (auto res = core::ir::ValidateAndDumpIfNeeded(mod, "end of lowering from SPIR-V");
- res != Success) {
+ if (auto res = core::ir::ValidateAndDumpIfNeeded(mod, "spirv.Lower"); res != Success) {
return res.Failure();
}
diff --git a/src/tint/lang/spirv/reader/lower/shader_io.cc b/src/tint/lang/spirv/reader/lower/shader_io.cc
index 24d4601..294f859 100644
--- a/src/tint/lang/spirv/reader/lower/shader_io.cc
+++ b/src/tint/lang/spirv/reader/lower/shader_io.cc
@@ -384,7 +384,7 @@
} // namespace
Result<SuccessType> ShaderIO(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "ShaderIO transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.ShaderIO");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/spirv/reader/lower/vector_element_pointer.cc b/src/tint/lang/spirv/reader/lower/vector_element_pointer.cc
index fa84275..f1f14cc 100644
--- a/src/tint/lang/spirv/reader/lower/vector_element_pointer.cc
+++ b/src/tint/lang/spirv/reader/lower/vector_element_pointer.cc
@@ -153,7 +153,7 @@
} // namespace
Result<SuccessType> VectorElementPointer(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "VectorElementPointer transform",
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.VectorElementPointer",
core::ir::Capabilities{
core::ir::Capability::kAllowVectorElementPointer,
});
diff --git a/src/tint/lang/spirv/writer/printer/printer.cc b/src/tint/lang/spirv/writer/printer/printer.cc
index c539a97..068b033 100644
--- a/src/tint/lang/spirv/writer/printer/printer.cc
+++ b/src/tint/lang/spirv/writer/printer/printer.cc
@@ -278,7 +278,7 @@
/// Builds the SPIR-V from the IR
Result<SuccessType> Generate() {
- auto valid = core::ir::ValidateAndDumpIfNeeded(ir_, "SPIR-V writer");
+ auto valid = core::ir::ValidateAndDumpIfNeeded(ir_, "spirv.Printer");
if (valid != Success) {
return valid.Failure();
}
diff --git a/src/tint/lang/spirv/writer/raise/builtin_polyfill.cc b/src/tint/lang/spirv/writer/raise/builtin_polyfill.cc
index a414f7a..1048fbc 100644
--- a/src/tint/lang/spirv/writer/raise/builtin_polyfill.cc
+++ b/src/tint/lang/spirv/writer/raise/builtin_polyfill.cc
@@ -959,7 +959,7 @@
} // namespace
Result<SuccessType> BuiltinPolyfill(core::ir::Module& ir, bool use_vulkan_memory_model) {
- auto result = ValidateAndDumpIfNeeded(ir, "BuiltinPolyfill transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.BuiltinPolyfill");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/spirv/writer/raise/expand_implicit_splats.cc b/src/tint/lang/spirv/writer/raise/expand_implicit_splats.cc
index 2f4fdd7..c0d2f34 100644
--- a/src/tint/lang/spirv/writer/raise/expand_implicit_splats.cc
+++ b/src/tint/lang/spirv/writer/raise/expand_implicit_splats.cc
@@ -135,7 +135,7 @@
} // namespace
Result<SuccessType> ExpandImplicitSplats(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "ExpandImplicitSplats transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.ExpandImplicitSplats");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/spirv/writer/raise/handle_matrix_arithmetic.cc b/src/tint/lang/spirv/writer/raise/handle_matrix_arithmetic.cc
index cf7f106..679f4e0 100644
--- a/src/tint/lang/spirv/writer/raise/handle_matrix_arithmetic.cc
+++ b/src/tint/lang/spirv/writer/raise/handle_matrix_arithmetic.cc
@@ -163,7 +163,7 @@
} // namespace
Result<SuccessType> HandleMatrixArithmetic(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "HandleMatrixArithmetic transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.HandleMatrixArithmetic");
if (result != Success) {
return result.Failure();
}
diff --git a/src/tint/lang/spirv/writer/raise/merge_return.cc b/src/tint/lang/spirv/writer/raise/merge_return.cc
index dbfb4f1..47de1b8 100644
--- a/src/tint/lang/spirv/writer/raise/merge_return.cc
+++ b/src/tint/lang/spirv/writer/raise/merge_return.cc
@@ -322,7 +322,7 @@
} // namespace
Result<SuccessType> MergeReturn(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "MergeReturn transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.MergeReturn");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/spirv/writer/raise/pass_matrix_by_pointer.cc b/src/tint/lang/spirv/writer/raise/pass_matrix_by_pointer.cc
index ac58a5a..85b5d04 100644
--- a/src/tint/lang/spirv/writer/raise/pass_matrix_by_pointer.cc
+++ b/src/tint/lang/spirv/writer/raise/pass_matrix_by_pointer.cc
@@ -128,7 +128,7 @@
} // namespace
Result<SuccessType> PassMatrixByPointer(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "PassMatrixByPointer transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.PassMatrixByPointer");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/spirv/writer/raise/remove_unreachable_in_loop_continuing.cc b/src/tint/lang/spirv/writer/raise/remove_unreachable_in_loop_continuing.cc
index 4f1fcdb..5f534b4 100644
--- a/src/tint/lang/spirv/writer/raise/remove_unreachable_in_loop_continuing.cc
+++ b/src/tint/lang/spirv/writer/raise/remove_unreachable_in_loop_continuing.cc
@@ -94,7 +94,7 @@
} // namespace
Result<SuccessType> RemoveUnreachableInLoopContinuing(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "RemoveUnreachableInLoopContinuing transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.RemoveUnreachableInLoopContinuing");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/spirv/writer/raise/shader_io.cc b/src/tint/lang/spirv/writer/raise/shader_io.cc
index 53ae7a4..14c9e53 100644
--- a/src/tint/lang/spirv/writer/raise/shader_io.cc
+++ b/src/tint/lang/spirv/writer/raise/shader_io.cc
@@ -235,7 +235,7 @@
} // namespace
Result<SuccessType> ShaderIO(core::ir::Module& ir, const ShaderIOConfig& config) {
- auto result = ValidateAndDumpIfNeeded(ir, "ShaderIO transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.ShaderIO");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/spirv/writer/raise/var_for_dynamic_index.cc b/src/tint/lang/spirv/writer/raise/var_for_dynamic_index.cc
index 49655d5..ea336ae 100644
--- a/src/tint/lang/spirv/writer/raise/var_for_dynamic_index.cc
+++ b/src/tint/lang/spirv/writer/raise/var_for_dynamic_index.cc
@@ -251,7 +251,7 @@
} // namespace
Result<SuccessType> VarForDynamicIndex(core::ir::Module& ir) {
- auto result = ValidateAndDumpIfNeeded(ir, "VarForDynamicIndex transform");
+ auto result = ValidateAndDumpIfNeeded(ir, "spirv.VarForDynamicIndex");
if (result != Success) {
return result;
}
diff --git a/src/tint/lang/wgsl/reader/lower/lower.cc b/src/tint/lang/wgsl/reader/lower/lower.cc
index f7e690c..02ba26e 100644
--- a/src/tint/lang/wgsl/reader/lower/lower.cc
+++ b/src/tint/lang/wgsl/reader/lower/lower.cc
@@ -204,7 +204,7 @@
} // namespace
Result<SuccessType> Lower(core::ir::Module& mod) {
- if (auto res = core::ir::ValidateAndDumpIfNeeded(mod, "lowering from WGSL"); res != Success) {
+ if (auto res = core::ir::ValidateAndDumpIfNeeded(mod, "wgsl.Lower"); res != Success) {
return res.Failure();
}
diff --git a/src/tint/lang/wgsl/writer/raise/value_to_let.cc b/src/tint/lang/wgsl/writer/raise/value_to_let.cc
index 32e98b3..44fe8e5 100644
--- a/src/tint/lang/wgsl/writer/raise/value_to_let.cc
+++ b/src/tint/lang/wgsl/writer/raise/value_to_let.cc
@@ -186,7 +186,7 @@
} // namespace
Result<SuccessType> ValueToLet(core::ir::Module& ir) {
- auto result = core::ir::ValidateAndDumpIfNeeded(ir, "ValueToLet transform");
+ auto result = core::ir::ValidateAndDumpIfNeeded(ir, "wgsl.ValueToLet");
if (result != Success) {
return result;
}
