Add dawn-chromium-presubmit to all CLs
Adds dawn-chromium-presubmit to all Dawn CLs and prevents reuse of
builds. This should help prevent cases of expectation conflicts
making it in.
Bug: 352816949
Change-Id: Ia3c39cbdd07b9015f3df106f4d5bb5d85080727b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/203595
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
diff --git a/infra/config/global/generated/commit-queue.cfg b/infra/config/global/generated/commit-queue.cfg
index 4f7bc68..d8ce41f 100644
--- a/infra/config/global/generated/commit-queue.cfg
+++ b/infra/config/global/generated/commit-queue.cfg
@@ -82,7 +82,7 @@
}
builders {
name: "chromium/try/dawn-chromium-presubmit"
- includable_only: true
+ disable_reuse: true
}
builders {
name: "chromium/try/dawn-try-linux-x64-intel-uhd770-rel"
diff --git a/infra/config/global/main.star b/infra/config/global/main.star
index 4e78a8a..c395372 100755
--- a/infra/config/global/main.star
+++ b/infra/config/global/main.star
@@ -862,15 +862,6 @@
chromium_dawn_tryjob("android", "arm")
chromium_dawn_tryjob("android", "arm64")
-# TODO(crbug.com/352816949): Move this definition alongside the presubmit
-# trybot and make it run on every CL once we confirm that it works as expected
-# on Dawn CLs.
-luci.cq_tryjob_verifier(
- cq_group = "Dawn-CQ",
- builder = "chromium:try/dawn-chromium-presubmit",
- includable_only = True,
-)
-
tricium_dawn_tryjob()
luci.cq_tryjob_verifier(
@@ -942,6 +933,16 @@
includable_only = True,
)
+# This is separate from the "presubmit" builder for now since we do not want
+# it branched yet.
+# TODO(crbug.com/352816949): Decide whether or not we want this branched
+# long-term.
+luci.cq_tryjob_verifier(
+ cq_group = "Dawn-CQ",
+ builder = "chromium:try/dawn-chromium-presubmit",
+ disable_reuse = True,
+)
+
# Views
luci.milo(
