commit 74bf9dfd0bfbdf7ce11ec6cd7f2b1f02958cbf3c
author Corentin Wallez <cwallez@chromium.org> Sun Sep 17 18:13:03 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Sun Sep 17 18:13:03 2023 +0000
tree 79f53eecb5f915be60464f2394c8721d2b57ba6a
parent 43823c6a7cde206e8d41520c940b26bb1472e236

DeviceBase::Destroy only AssumeCommandsCompleted if we have a queue.

The queue could not be set if the device creation failed during
its initialization.

Bug: chromium:1474147
Bug: chromium:1475434
Bug: chromium:1480229
Change-Id: I3b2f7e1886abf12846cf1ef2006c4a9c29bf4e48
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/151460
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>

src/dawn/native/Device.cpp

diff --git a/src/dawn/native/Device.cpp b/src/dawn/native/Device.cpp
index 5d3f538..99db74d 100644
--- a/src/dawn/native/Device.cpp
+++ b/src/dawn/native/Device.cpp
@@ -511,7 +511,9 @@
     mInternalPipelineStore = nullptr;
     mExternalTexturePlaceholderView = nullptr;
 
-    mQueue->AssumeCommandsComplete();
+    if (mQueue != nullptr) {
+        mQueue->AssumeCommandsComplete();
+    }
 
     // Now that the GPU timeline is empty, destroy the backend device.
     DestroyImpl();