commit 75ef7c68c0ce1b4c11e6fc1e55aa9d3422e63768
author Brian Sheedy <bsheedy@google.com> Thu Apr 17 07:26:12 2025 -0700
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 17 07:26:12 2025 -0700
tree 825401db611db7cda071c4813d5bc3554ea47b93
parent b4ca9a347f458c704ae1eff90715623ecf21009e

Add missing standalone builder settings

Adds the following to the recently added Dawn standalone builder
configs:

1. builder_group for trybots (CI builders already had this)
2. ResultDB for trybots and CI testers
3. Build numbers for all builders

Bug: 385317083
Change-Id: I021c091ead723b4aa75dd9443c0acc7d2342a005
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/237478
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

infra/config/global/generated/cr-buildbucket.cfg

diff --git a/infra/config/global/generated/cr-buildbucket.cfg b/infra/config/global/generated/cr-buildbucket.cfg
index ab46677..55145d9 100644
--- a/infra/config/global/generated/cr-buildbucket.cfg
+++ b/infra/config/global/generated/cr-buildbucket.cfg
@@ -593,6 +593,7 @@
         '  "builder_group": "dawn",'
         '  "recipe": "dawn/gn_v2"'
         '}'
+      build_numbers: YES
       service_account: "dawn-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
       experiments {
         key: "luci.recipes.use_python3"
@@ -639,11 +640,15 @@
         '  "builder_group": "dawn",'
         '  "recipe": "dawn/gn_v2"'
         '}'
+      build_numbers: YES
       service_account: "dawn-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
       experiments {
         key: "luci.recipes.use_python3"
         value: 100
       }
+      resultdb {
+        enable: true
+      }
       shadow_builder_adjustments {
         service_account: "dawn-try-builder@chops-service-accounts.iam.gserviceaccount.com"
       }
@@ -1457,13 +1462,18 @@
         '    "project": "rbe-chromium-untrusted",'
         '    "remote_jobs": 250'
         '  },'
+        '  "builder_group": "dawn",'
         '  "recipe": "dawn/gn_v2_trybot"'
         '}'
+      build_numbers: YES
       service_account: "dawn-try-builder@chops-service-accounts.iam.gserviceaccount.com"
       experiments {
         key: "luci.recipes.use_python3"
         value: 100
       }
+      resultdb {
+        enable: true
+      }
     }
     builders {
       name: "linux-clang-dbg-x64"

infra/config/global/gn_standalone_ci.star

diff --git a/infra/config/global/gn_standalone_ci.star b/infra/config/global/gn_standalone_ci.star
index 6b346f1..142e6e8 100644
--- a/infra/config/global/gn_standalone_ci.star
+++ b/infra/config/global/gn_standalone_ci.star
@@ -87,6 +87,7 @@
         dimensions = dimensions,
         properties = generate_properties_for_project(siso.project.DEFAULT_TRUSTED),
         shadow_properties = generate_properties_for_project(siso.project.DEFAULT_UNTRUSTED),
+        build_numbers = True,
         # TODO(crbug.com/385317083): Make CI builders notify the gardeners once
         # migration to this recipe has begun.
         service_account = CI_SERVICE_ACCOUNT,
@@ -114,6 +115,8 @@
         properties = {
             "builder_group": "dawn",
         },
+        build_numbers = True,
+        resultdb_settings = resultdb.settings(enable = True),
         service_account = CI_SERVICE_ACCOUNT,
         shadow_service_account = CI_SHADOW_SERVICE_ACCOUNT,
     )

infra/config/global/gn_standalone_try.star

diff --git a/infra/config/global/gn_standalone_try.star b/infra/config/global/gn_standalone_try.star
index dd7deb4..1e74874 100644
--- a/infra/config/global/gn_standalone_try.star
+++ b/infra/config/global/gn_standalone_try.star
@@ -49,6 +49,7 @@
 
 def generate_properties():
     properties = {
+        "builder_group": "dawn",
         "$build/siso": {
             "project": siso.project.DEFAULT_UNTRUSTED,
             "remote_jobs": siso.remote_jobs.DEFAULT,
@@ -83,6 +84,8 @@
         executable = "recipe:dawn/gn_v2_trybot",
         properties = generate_properties(),
         dimensions = dimensions,
+        build_numbers = True,
+        resultdb_settings = resultdb.settings(enable = True),
         service_account = TRY_SERVICE_ACCOUNT,
     )