commit 77a90cb796f9affe6ac876768a8b08e2b85a9190
author Ben Clayton <bclayton@google.com> Mon Mar 06 18:25:08 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 06 18:25:08 2023 +0000
tree aacae73d498ba68a974fa7b17fff3f441224f90c
parent a753ad47a48fc0fba6e617b7ffcddc0e1fdc4b2e

test/tint/builtins/gen: Use returned value

It appears that FXC and DXC do some validation post dead-code-elimination.
These tests have been updated so that the return value is assigned to a storage buffer, ensuring that all validation is performed.

Many DXC tests are affected by https://github.com/microsoft/DirectXShaderCompiler/issues/5082, which have been SKIP'ed.

Fixed: tint:1859
Change-Id: I0001a9a9821846cd0855c3d8ce2bec79ab8e64ef
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/122662
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>

test/tint/builtins/gen/literal/log2/fb9f0b.wgsl.expected.msl

diff --git a/test/tint/builtins/gen/literal/log2/fb9f0b.wgsl.expected.msl b/test/tint/builtins/gen/literal/log2/fb9f0b.wgsl.expected.msl
index 0e844fd..b44bdcd 100644
--- a/test/tint/builtins/gen/literal/log2/fb9f0b.wgsl.expected.msl
+++ b/test/tint/builtins/gen/literal/log2/fb9f0b.wgsl.expected.msl
@@ -1,33 +1,34 @@
 #include <metal_stdlib>
 
 using namespace metal;
-void log2_fb9f0b() {
+void log2_fb9f0b(device half2* const tint_symbol_1) {
   half2 res = half2(0.0h);
+  *(tint_symbol_1) = res;
 }
 
 struct tint_symbol {
   float4 value [[position]];
 };
 
-float4 vertex_main_inner() {
-  log2_fb9f0b();
+float4 vertex_main_inner(device half2* const tint_symbol_2) {
+  log2_fb9f0b(tint_symbol_2);
   return float4(0.0f);
 }
 
-vertex tint_symbol vertex_main() {
-  float4 const inner_result = vertex_main_inner();
+vertex tint_symbol vertex_main(device half2* tint_symbol_3 [[buffer(0)]]) {
+  float4 const inner_result = vertex_main_inner(tint_symbol_3);
   tint_symbol wrapper_result = {};
   wrapper_result.value = inner_result;
   return wrapper_result;
 }
 
-fragment void fragment_main() {
-  log2_fb9f0b();
+fragment void fragment_main(device half2* tint_symbol_4 [[buffer(0)]]) {
+  log2_fb9f0b(tint_symbol_4);
   return;
 }
 
-kernel void compute_main() {
-  log2_fb9f0b();
+kernel void compute_main(device half2* tint_symbol_5 [[buffer(0)]]) {
+  log2_fb9f0b(tint_symbol_5);
   return;
 }