commit 78016b8949db0418dec4e89f60f43941905f135c
author Antonio Maiorano <amaiorano@google.com> Tue Nov 05 16:03:16 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 05 16:03:16 2024 +0000
tree 6e5fa97667e6b43ae312cae697cfc941fce914c8
parent 08b478b3f3a375c276ede374ae8b9eb72d6b2583

HLSL-IR: Remove TODOs that are already done

Bug: 377358589
Change-Id: I5e3492afe16a78323f8896e85d6932608af9f0cb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/213834
Auto-Submit: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>

src/tint/lang/hlsl/writer/printer/printer.cc

diff --git a/src/tint/lang/hlsl/writer/printer/printer.cc b/src/tint/lang/hlsl/writer/printer/printer.cc
index d73f45f..d8bf121 100644
--- a/src/tint/lang/hlsl/writer/printer/printer.cc
+++ b/src/tint/lang/hlsl/writer/printer/printer.cc
@@ -1079,9 +1079,6 @@
     /// Emit a binary instruction
     /// @param b the binary instruction
     void EmitBinary(StringStream& out, const core::ir::CoreBinary* b) {
-        // TODO(dsinclair): Short circuring transform
-        // TODO(dsinclair): Transform matrix multiplication into a `mul` instruction
-
         auto kind = [&] {
             switch (b->Op()) {
                 case core::BinaryOp::kAdd:

src/tint/lang/hlsl/writer/raise/raise.cc

diff --git a/src/tint/lang/hlsl/writer/raise/raise.cc b/src/tint/lang/hlsl/writer/raise/raise.cc
index 90bdaea..5778fdf 100644
--- a/src/tint/lang/hlsl/writer/raise/raise.cc
+++ b/src/tint/lang/hlsl/writer/raise/raise.cc
@@ -88,10 +88,7 @@
     }
 
     {
-        // TODO(dsinclair): Add missing polyfills
-
         core::ir::transform::BuiltinPolyfillConfig core_polyfills{};
-        // core_polyfills.bitshift_modulo = true;
         core_polyfills.clamp_int = true;
         core_polyfills.dot_4x8_packed = options.polyfill_dot_4x8_packed;
 
@@ -105,7 +102,6 @@
         core_polyfills.first_trailing_bit = true;
         core_polyfills.fwidth_fine = true;
         core_polyfills.insert_bits = core::ir::transform::BuiltinPolyfillLevel::kFull;
-        // core_polyfills.int_div_mod = !options.disable_polyfill_integer_div_mod;
 
         // Currently Pack4xU8Clamp() must be polyfilled because on latest DXC pack_clamp_u8()
         // receives an int32_t4 as its input.
@@ -113,9 +109,9 @@
         core_polyfills.pack_4xu8_clamp = true;
         core_polyfills.pack_unpack_4x8 = options.polyfill_pack_unpack_4x8;
         core_polyfills.radians = true;
+        // TODO(crbug.com/377357960): Implement reflect_vec2_f32
         // core_polyfills.reflect_vec2_f32 = options.polyfill_reflect_vec2_f32;
         core_polyfills.texture_sample_base_clamp_to_edge_2d_f32 = true;
-        // core_polyfills.workgroup_uniform_load = true;
         RUN_TRANSFORM(core::ir::transform::BuiltinPolyfill, module, core_polyfills);
     }
 
@@ -143,7 +139,7 @@
         // according to the description of the assembly store_uav_typed, out of bounds addressing
         // means nothing gets written to memory.
         //
-        // TODO(dsinclair): Need to translate this into new robustness.
+        // TODO(crbug.com/377360326): Implement ignore for texture actions for performance
         // config.texture_action = ast::transform::Robustness::Action::kIgnore;
 
         RUN_TRANSFORM(core::ir::transform::Robustness, module, config);