commit 790e4c2d60ffba5a0c20f209c94cdcdaa8bbd3d1
author Stephen White <senorblanco@chromium.org> Fri Apr 22 21:25:02 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Apr 22 21:25:02 2022 +0000
tree 00fca66ec3a9f7356b9126306342abf2db5bf059
parent c0fe68907baeebaf192cc45cbbd81c55096cb2c7

GLSL writer: emit gl_PointSize = 1 in all vertex shaders for OpenGL.

The OpenGL ES 3.1 spec says:

"The point size is taken from the shader built-in gl_PointSize written by the vertex shader, and clamped to the implementation-dependent point size range. If the value written to gl_PointSize is less than or equal to zero, or if no value is written, the point size is undefined."

ANGLE/D3D11 will emit a warning on this and abort processing, causing dawn_end2end tests to fail.

Bug: dawn:1390
Change-Id: I6a56467842ba80d8a070af7240ee07bb111089dd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87720
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>

test/tint/builtins/gen/textureGather/15d79c.wgsl.expected.glsl

diff --git a/test/tint/builtins/gen/textureGather/15d79c.wgsl.expected.glsl b/test/tint/builtins/gen/textureGather/15d79c.wgsl.expected.glsl
index 0c1a85e..483b2d4 100644
--- a/test/tint/builtins/gen/textureGather/15d79c.wgsl.expected.glsl
+++ b/test/tint/builtins/gen/textureGather/15d79c.wgsl.expected.glsl
@@ -12,6 +12,7 @@
 }
 
 void main() {
+  gl_PointSize = 1.0;
   vec4 inner_result = vertex_main();
   gl_Position = inner_result;
   gl_Position.y = -(gl_Position.y);