commit 7b889ed62f83caa08a1c826956ea2c338ca9e65d
author David Neto <dneto@google.com> Fri Jun 27 13:48:58 2025 -0700
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 27 13:48:58 2025 -0700
tree 90606ce6b8435ca3831f2c7294c8f4571b9a5886
parent 4449c456bb95595523cc46f603a1b76ebff26ef2

spirv-reader: spec constant op Sconvert, UConvert not supported

SConvert and UConvert convert between integer types of different widths.
WGSL only has 32-bit (concrete) integer types, so make the reader ICE.

Fixed: crbug.com/402726347 crbug.com/402726598
Change-Id: I47b1461bcde80c51f26585a33438877867d8aaa9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/249534
Reviewed-by: James Price <jrprice@google.com>
Auto-Submit: David Neto <dneto@google.com>
Commit-Queue: David Neto <dneto@google.com>

src/tint/lang/spirv/reader/parser/parser.cc

diff --git a/src/tint/lang/spirv/reader/parser/parser.cc b/src/tint/lang/spirv/reader/parser/parser.cc
index ffcfde6..6cd964b 100644
--- a/src/tint/lang/spirv/reader/parser/parser.cc
+++ b/src/tint/lang/spirv/reader/parser/parser.cc
@@ -364,6 +364,12 @@
                         case spv::Op::OpNot:
                             EmitSpirvExplicitBuiltinCall(inst, spirv::BuiltinFn::kNot, 3);
                             break;
+                        case spv::Op::OpSConvert:
+                            TINT_ICE() << "can't translate SConvert: WGSL does not have concrete "
+                                          "integer types of different widths";
+                        case spv::Op::OpUConvert:
+                            TINT_ICE() << "can't translate UConvert: WGSL does not have concrete "
+                                          "integer types of different widths";
                         default:
                             TINT_ICE() << "Unknown spec constant operation: " << op;
                     }