commit 7ce555e6823f79ff224ef8bc9c8345ca71ee9ee4
author Ben Clayton <bclayton@google.com> Mon Jan 22 14:54:01 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 22 14:54:01 2024 +0000
tree e3dc390e4904c8689cf73becb3b62abd07ec15ba
parent ffd485c685040edb1e678165dcbf0e841cfa0298

[dawn] Fix call to missing copy-constructor

SystemHandle has an implicitly deleted copy constructor, but a return via implicit wrapping of a ResultOrError was causing some compilers to try to use the copy-constructor.
Instead, explicitly move to a ResultOrError.

Change-Id: Ib08eab89a03feb67a7c5047355cb5290bb662951
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/170860
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>

src/dawn/native/SystemHandle.h

diff --git a/src/dawn/native/SystemHandle.h b/src/dawn/native/SystemHandle.h
index 4026ba42..ea3460f 100644
--- a/src/dawn/native/SystemHandle.h
+++ b/src/dawn/native/SystemHandle.h
@@ -28,6 +28,8 @@
 #ifndef SRC_DAWN_NATIVE_SYSTEMHANDLE_H_
 #define SRC_DAWN_NATIVE_SYSTEMHANDLE_H_
 
+#include <utility>
+
 #include "dawn/common/NonCopyable.h"
 #include "dawn/common/Platform.h"
 #include "dawn/native/Error.h"
@@ -66,7 +68,7 @@
         SystemHandle dupHandle;
         DAWN_TRY_ASSIGN(dupHandle, tmpOwnedHandle.Duplicate());
         tmpOwnedHandle.Detach();
-        return dupHandle;
+        return ResultOrError<SystemHandle>{std::move(dupHandle)};
     }
 
     bool IsValid() const;