commit 8667236e1efae1d2e90483c70f80556d9c903927
author Corentin Wallez <cwallez@chromium.org> Fri Jan 12 10:39:37 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 12 10:39:37 2024 +0000
tree 002329f88d1c5dd26a21a82c61224763eb30aff4
parent dd817230abc003ee1924056dd813b6b383db4588

Remove unnecessary DAWN_NOINLINE

Bug: None
Change-Id: If80c848ce38a286e3cf0991275a599b58224878e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/169200
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

src/dawn/common/Compiler.h

diff --git a/src/dawn/common/Compiler.h b/src/dawn/common/Compiler.h
index 21fead8..2e28414 100644
--- a/src/dawn/common/Compiler.h
+++ b/src/dawn/common/Compiler.h
@@ -122,20 +122,6 @@
 // Prevents unused variable/expression warnings on FUNC.
 #define DAWN_UNUSED_FUNC(FUNC) static_assert(sizeof(&FUNC) == sizeof(void (*)()))
 
-// DAWN_NOINLINE
-//
-// Annotate a function indicating it should not be inlined. Use like:
-// DAWN_NOINLINE void DoStuff() { ... }
-#if defined(__clang__) && DAWN_HAS_ATTRIBUTE(noinline)
-#define DAWN_NOINLINE [[clang::noinline]]
-#elif defined(__GNUC__) && DAWN_HAS_ATTRIBUTE(noinline)
-#define DAWN_NOINLINE __attribute__((noinline))
-#elif defined(_MSC_VER)
-#define DAWN_NOINLINE __declspec(noinline)
-#else
-#define DAWN_NOINLINE
-#endif
-
 // DAWN_FORCE_INLINE
 //
 // Annotate a function indicating it should really never be inline, even in debug mode.

src/dawn/native/metal/UtilsMetal.mm

diff --git a/src/dawn/native/metal/UtilsMetal.mm b/src/dawn/native/metal/UtilsMetal.mm
index 8d17cd0..2b256da 100644
--- a/src/dawn/native/metal/UtilsMetal.mm
+++ b/src/dawn/native/metal/UtilsMetal.mm
@@ -908,7 +908,7 @@
         [&](id<MTLRenderCommandEncoder>, BeginRenderPassCmd*) -> MaybeError { return {}; });
 }
 
-DAWN_NOINLINE bool SupportCounterSamplingAtCommandBoundary(id<MTLDevice> device)
+bool SupportCounterSamplingAtCommandBoundary(id<MTLDevice> device)
     API_AVAILABLE(macos(11.0), ios(14.0)) {
     bool isBlitBoundarySupported =
         [device supportsCounterSampling:MTLCounterSamplingPointAtBlitBoundary];
@@ -920,7 +920,7 @@
     return isBlitBoundarySupported && isDispatchBoundarySupported && isDrawBoundarySupported;
 }
 
-DAWN_NOINLINE bool SupportCounterSamplingAtStageBoundary(id<MTLDevice> device)
+bool SupportCounterSamplingAtStageBoundary(id<MTLDevice> device)
     API_AVAILABLE(macos(11.0), ios(14.0)) {
     return [device supportsCounterSampling:MTLCounterSamplingPointAtStageBoundary];
 }