commit 89bfec45fb8090265b60b40862f75c55a44d16e4
author dan sinclair <dsinclair@chromium.org> Mon Jun 24 21:56:32 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 24 21:56:32 2024 +0000
tree 961d4485dc4935fc1f67ed7296bda78e35557fb8
parent 08f3865189c47c063c1032e26c2360aff2d79217

[hlsl] Remove Logical And/Or test stubs

There are no logical `&&` or `||` statements in the IR. They're
removed during the conversion from WGSL. Remove the accidentally added
tests.

Bug: 42251045
Change-Id: I059194b705014297d3cbf2a75e4bf74d0c486cf9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/195415
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: James Price <jrprice@google.com>

src/tint/lang/hlsl/writer/binary_test.cc

diff --git a/src/tint/lang/hlsl/writer/binary_test.cc b/src/tint/lang/hlsl/writer/binary_test.cc
index 20baca7..4642586 100644
--- a/src/tint/lang/hlsl/writer/binary_test.cc
+++ b/src/tint/lang/hlsl/writer/binary_test.cc
@@ -419,66 +419,6 @@
 }
 
 // TODO(dsinclair): Needs binary polyfill
-TEST_F(HlslWriterTest, DISABLED_BinaryLogicalAnd) {
-    auto* func = b.Function("foo", ty.void_(), core::ir::Function::PipelineStage::kCompute);
-    func->SetWorkgroupSize(1, 1, 1);
-    b.Append(func->Block(), [&] {
-        auto* x = b.Var("x", true);
-        auto* y = b.Var("y", false);
-
-        auto* l = b.Load(x);
-        auto* r = b.Load(y);
-        b.Var("c", b.Binary(core::BinaryOp::kLogicalAnd, ty.bool_(), l, r));
-        b.Return(func);
-    });
-
-    ASSERT_TRUE(Generate()) << err_ << output_.hlsl;
-    EXPECT_EQ(output_.hlsl, R"(
-[numthreads(1, 1, 1)]
-void foo() {
-  bool x = true;
-  bool y = false;
-  bool tint_tmp = x;
-  if (tint_tmp) {
-    tint_tmp = y;
-  }
-  bool c = (tint_tmp);
-}
-
-)");
-}
-
-// TODO(dsinclair): Needs binary polyfill
-TEST_F(HlslWriterTest, DISABLED_BinaryLogicalOr) {
-    auto* func = b.Function("foo", ty.void_(), core::ir::Function::PipelineStage::kCompute);
-    func->SetWorkgroupSize(1, 1, 1);
-    b.Append(func->Block(), [&] {
-        auto* x = b.Var("x", true);
-        auto* y = b.Var("y", false);
-
-        auto* l = b.Load(x);
-        auto* r = b.Load(y);
-        b.Var("c", b.Binary(core::BinaryOp::kLogicalOr, ty.bool_(), l, r));
-        b.Return(func);
-    });
-
-    ASSERT_TRUE(Generate()) << err_ << output_.hlsl;
-    EXPECT_EQ(output_.hlsl, R"(
-[numthreads(1, 1, 1)]
-void foo() {
-  bool a = true;
-  bool b = false;
-  bool tint_tmp = x;
-  if (!tint_tmp) {
-    tint_tmp = y;
-  }
-  bool c = (tint_tmp);
-}
-
-)");
-}
-
-// TODO(dsinclair): Needs binary polyfill
 TEST_F(HlslWriterTest, DISABLED_BinaryMulMatVec) {
     auto* func = b.Function("foo", ty.void_(), core::ir::Function::PipelineStage::kCompute);
     func->SetWorkgroupSize(1, 1, 1);