commit 8cc71652982582bd599693ddd6dc373a476f8ae5
author Jiawei Shao <jiawei.shao@intel.com> Mon Jan 13 16:57:42 2025 -0800
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 13 16:57:42 2025 -0800
tree e4e0f04d4da6a396e67c80dba9470bb24ebc1123
parent da67732fb6aefd45296048498c820b796b06d3ca

Make `DynamicUploader::ReleaseStagingBuffer` a private function

This patch makes `DynamicUploader::ReleaseStagingBuffer()` a private
function instead of a public one as now it won't be used outside
`DynamicUploader`.

Bug: 42242066
Change-Id: I09e12021933f66a34377d4c33fd24048bb642e20
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/221854
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Loko Kung <lokokung@google.com>

src/dawn/native/DynamicUploader.h

diff --git a/src/dawn/native/DynamicUploader.h b/src/dawn/native/DynamicUploader.h
index ac73941..f9e1d8d 100644
--- a/src/dawn/native/DynamicUploader.h
+++ b/src/dawn/native/DynamicUploader.h
@@ -55,12 +55,6 @@
     explicit DynamicUploader(DeviceBase* device);
     ~DynamicUploader() = default;
 
-    // We add functions to Release StagingBuffers to the DynamicUploader as there's
-    // currently no place to track the allocated staging buffers such that they're freed after
-    // pending commands are finished. This should be changed when better resource allocation is
-    // implemented.
-    void ReleaseStagingBuffer(Ref<BufferBase> stagingBuffer);
-
     ResultOrError<UploadHandle> Allocate(uint64_t allocationSize,
                                          ExecutionSerial serial,
                                          uint64_t offsetAlignment);
@@ -81,6 +75,8 @@
                                                  ExecutionSerial serial,
                                                  uint64_t offsetAlignment);
 
+    void ReleaseStagingBuffer(Ref<BufferBase> stagingBuffer);
+
     std::vector<std::unique_ptr<RingBuffer>> mRingBuffers;
     SerialQueue<ExecutionSerial, Ref<BufferBase>> mReleasedStagingBuffers;
     raw_ptr<DeviceBase> mDevice;