commit | 1e1c13ed87bae248e044fdd6fec9c5ab7efccf41 | [log] [tgz] |
---|---|---|
author | Jiawei Shao <jiawei.shao@intel.com> | Mon Mar 11 18:41:02 2019 +0000 |
committer | Commit Bot service account <commit-bot@chromium.org> | Mon Mar 11 18:41:02 2019 +0000 |
tree | 8258f6d59d297aeb83345165f68fb57255fe2055 | |
parent | d030f64550d871ca7d8b2364a81054daafe9a799 [diff] |
Add validations to multisampled color attachments and resolve targets This patch adds validations to the multisampled color attachments and resolve targets. The resolve target must be a valid texture view, and it must follow the following validations: According to Vulkan SPEC: 1. If we set resolve target, the texture of the color attachment must be a multisampled texture, and the texture of the resolve target must be a non-multisampled texture. 2. The format of the resolve target must be the same as that of the color attachment. 3. The sample count of all the color attachments must be same. 4. The resolve target must have dawn::TextureUsage::OutputAttachment usage bit set when it was created. On D3D12: 1. ID3D12GraphicsCommandList::ResolveSubresource() method only allow resolving in a subresource of a texture, thus the level count and mipmap level count of the resolve target can only be 1. 2. ID3D12GraphicsCommandList::ResolveSubresource() method requires the dimension of the source and destination must match. BUG=dawn:56 TEST=dawn_unittests Change-Id: I080415bef0d600600083a95f641815188798dca3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5340 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Dawn (formerly NXT) is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. It exposes a C/C++ API that maps almost one-to-one to the WebGPU IDL and can be managed as part of a larger system such as a Web browser.
Dawn provides several WebGPU building blocks:
dawn.json
: description of the API used to drive code generators.examples
: examples showing how Dawn is used.generator
: code generator for files produces from dawn.json
templates
: Jinja2 templates for the generatorscripts
: scripts to support things like continuous testing, build files, etc.src
:common
: helper code shared between core Dawn libraries and tests/samplesdawn_native
: native implementation of WebGPU, one subfolder per backenddawn_wire
: client-server implementation of WebGPUinclude
: public headers for Dawntests
: internal Dawn testsend2end
: WebGPU tests performing GPU operationsunittests
: unittests and by extension tests not using the GPUvalidation
: WebGPU validation tests not using the GPU (frontend tests)utils
: helper code to use Dawn used by tests and samplesthird_party
: directory where dependencies live as well as their buildfiles.Dawn uses the Chromium build system and dependency management so you need to install depot_tools and add it to the PATH.
On Linux you need to have the pkg-config
command:
# Install pkg-config on Ubuntu sudo apt-get install pkg-config
Then get the source as follows:
# Clone the repo as "dawn" git clone https://dawn.googlesource.com/dawn dawn && cd dawn # Bootstrap the gclient configuration cp scripts/standalone.gclient .gclient # Fetch external dependencies and toolchains with gclient gclient sync
Then generate build files using gn args out/Debug
or gn args out/Release
. A text editor will appear asking build options, the most common option is is_debug=true/false
; otherwise gn args out/Release --list
shows all the possible options.
Then use ninja -C out/Release
to build dawn and for example ./out/Release/dawn_end2end_tests
to run the tests.
Please read and follow CONTRIBUTING.md. Dawn doesn‘t have a formal coding style yet, except what’s defined by our clang format style. Overall try to use the same style and convention as code around your change.
If you find issues with Dawn, please feel free to report them on the bug tracker. For other discussions, please post to Dawn's mailing list.
Please see LICENSE.
This is not an officially supported Google product.