commit 9a62e36a1b1a0073fbdd3575ffe721f99f3d21f5
author dan sinclair <dsinclair@chromium.org> Wed Nov 06 21:24:00 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Nov 06 21:24:00 2024 +0000
tree 70badf053f9d0766d0fc82523667e447e7e824c0
parent 5396ee1a82674202c199b8974f7727aacdabb226

[spirv] Update generate_bindings to handle Overrides.

This CL updates the GenerateBindings for the SPIR-V backend to allow
more then just `Var` entries at module scope.

Bug: 374971092
Change-Id: I19173b08927181579c721b8cb9a5615e602f3c48
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/214174
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>

src/tint/lang/spirv/writer/helpers/generate_bindings.cc

diff --git a/src/tint/lang/spirv/writer/helpers/generate_bindings.cc b/src/tint/lang/spirv/writer/helpers/generate_bindings.cc
index ad38631..66cdf54 100644
--- a/src/tint/lang/spirv/writer/helpers/generate_bindings.cc
+++ b/src/tint/lang/spirv/writer/helpers/generate_bindings.cc
@@ -51,10 +51,11 @@
     Hashmap<uint32_t, uint32_t, 4> group_to_next_binding_number;
     Vector<tint::BindingPoint, 4> ext_tex_bps;
     for (auto* inst : *module.root_block) {
-        if (!inst->Alive()) {
+        auto* var = inst->As<core::ir::Var>();
+        if (!var) {
             continue;
         }
-        auto* var = inst->As<core::ir::Var>();
+
         if (auto bp = var->BindingPoint()) {
             if (auto val = group_to_next_binding_number.Get(bp->group)) {
                 *val = std::max(*val, bp->binding + 1);