commit 9f174e9a360eadb521055b750f695640c7d30903
author James Price <jrprice@google.com> Wed Sep 04 20:01:23 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 04 20:01:23 2024 +0000
tree 69378cd5a979e292d5ae0a51e320e4b6c5dd8a70
parent 2261163e0c2345df8cebc1ddc470dfbbe81a23b0

[msl] Enable and fix floating point modulo tests

Bug: 42251016
Change-Id: I9c58ae22f51b449a188ebde810bc3ff2b6bda5d5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/205415
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: James Price <jrprice@google.com>

src/tint/lang/msl/writer/binary_test.cc

diff --git a/src/tint/lang/msl/writer/binary_test.cc b/src/tint/lang/msl/writer/binary_test.cc
index 9e8f89d..196f8ca 100644
--- a/src/tint/lang/msl/writer/binary_test.cc
+++ b/src/tint/lang/msl/writer/binary_test.cc
@@ -371,7 +371,7 @@
                          MslWriterBinaryTest_ShiftSignedOverflowDefinedBehaviour_Chained,
                          testing::ValuesIn(shift_signed_overflow_defined_behaviour_chained_cases));
 
-TEST_F(MslWriterTest, DISABLED_BinaryModF32) {
+TEST_F(MslWriterTest, BinaryModF32) {
     auto* func = b.Function("foo", ty.void_());
     b.Append(func->Block(), [&] {
         auto* left = b.Var("left", ty.ptr<core::AddressSpace::kFunction, f32>());
@@ -391,10 +391,11 @@
   float left = 0.0f;
   float right = 0.0f;
   float const val = fmod(left, right);
+}
 )");
 }
 
-TEST_F(MslWriterTest, DISABLED_BinaryModF16) {
+TEST_F(MslWriterTest, BinaryModF16) {
     auto* func = b.Function("foo", ty.void_());
     b.Append(func->Block(), [&] {
         auto* left = b.Var("left", ty.ptr<core::AddressSpace::kFunction, f16>());
@@ -414,10 +415,11 @@
   half left = 0.0h;
   half right = 0.0h;
   half const val = fmod(left, right);
+}
 )");
 }
 
-TEST_F(MslWriterTest, DISABLED_BinaryModVec3F32) {
+TEST_F(MslWriterTest, BinaryModVec3F32) {
     auto* func = b.Function("foo", ty.void_());
     b.Append(func->Block(), [&] {
         auto* left = b.Var("left", ty.ptr(core::AddressSpace::kFunction, ty.vec3<f32>()));
@@ -437,10 +439,11 @@
   float3 left = 0.0f;
   float3 right = 0.0f;
   float3 const val = fmod(left, right);
+}
 )");
 }
 
-TEST_F(MslWriterTest, DISABLED_BinaryModVec3F16) {
+TEST_F(MslWriterTest, BinaryModVec3F16) {
     auto* func = b.Function("foo", ty.void_());
     b.Append(func->Block(), [&] {
         auto* left = b.Var("left", ty.ptr(core::AddressSpace::kFunction, ty.vec3<f16>()));
@@ -460,6 +463,7 @@
   half3 left = 0.0h;
   half3 right = 0.0h;
   half3 const val = fmod(left, right);
+}
 )");
 }