commit a5e4715134f7b4c4ab20ec87cef81b6fcd8840ec
author Jaswant Panchumarti <jaswant.panchumarti@kitware.com> Thu Jul 04 16:04:58 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jul 04 16:04:58 2024 +0000
tree 5ef9cc425a6230b7a46ac8318e5f5828189cf387
parent 5a26bdd62d0f809626214c8a3448a988bcd25736

Revert "Do not turn off CMAKE_CXX_EXTENSIONS"

This reverts commit 42159c6902e7e74d59cfd490a6d90da2b9d3467a
and removes the TODO item in src/dawn/native/CMakeLists.txt

Change-Id: Id001f97010c5494e21fc8242310891ed47774328
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/196614
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Jaswant Panchumarti <jaswant.panchumarti@kitware.com>

src/cmake/DawnCompilerChecks.cmake

diff --git a/src/cmake/DawnCompilerChecks.cmake b/src/cmake/DawnCompilerChecks.cmake
index 3b597b3..d8bbe42 100644
--- a/src/cmake/DawnCompilerChecks.cmake
+++ b/src/cmake/DawnCompilerChecks.cmake
@@ -30,3 +30,4 @@
 # dawn_add_library still have the C++17 compiler flags enabled
 set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED True)
+set(CMAKE_CXX_EXTENSIONS False)

src/dawn/native/CMakeLists.txt

diff --git a/src/dawn/native/CMakeLists.txt b/src/dawn/native/CMakeLists.txt
index aec51ef..16e4c02 100644
--- a/src/dawn/native/CMakeLists.txt
+++ b/src/dawn/native/CMakeLists.txt
@@ -883,8 +883,6 @@
             "WGPU_SHARED_LIBRARY"
             "DAWN_NATIVE_SHARED_LIBRARY"
     )
-    # TODO: Revert https://dawn-review.googlesource.com/c/dawn/+/196361 and remove the next line.
-    set_target_properties(webgpu_dawn PROPERTIES CXX_EXTENSIONS NO)
     # Apart from dawn_public_config, everything else goes inside PRIVATE, otherwise install rules will complain that they were not exported.
     target_link_libraries(webgpu_dawn
         PUBLIC