| commit | a87c5333bf91c8c1eec2518c01235f311d7ccb0c | [log] [tgz] |
|---|---|---|
| author | Robert Phillips <robertphillips@google.com> | Mon May 06 14:43:48 2024 +0000 |
| committer | Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 06 14:43:48 2024 +0000 |
| tree | 43917f1b7a7fc3e91eeb04e1fed617c534da9d48 | |
| parent | f4b20dc4d1de10251c36007dba36a8bce53bbca4 [diff] |
Add "delayimp.lib" linking to fix unresolved external symbol __delayLoadHelper2 issue The CL: https://dawn-review.googlesource.com/c/dawn/+/186820 (Add delayloads config to dawn_native component) added delayed loading of user32.dll. This appears to be blocking the Dawn roll into Skia with the error: error LNK2001: unresolved external symbol __delayLoadHelper2 on the Build-Win-MSVC-x86_64-Debug-Graphite_Dawn_D3D12 bot (https://skia-review.googlesource.com/c/skia/+/848904). This CL seems to fix the link error locally on my machine. Change-Id: I562b6fb55c6b6dc2328e238ff41fa05c2da1df89 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/186921 Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com>
diff --git a/src/dawn/native/BUILD.gn b/src/dawn/native/BUILD.gn index 54c0cde..efc266a 100644 --- a/src/dawn/native/BUILD.gn +++ b/src/dawn/native/BUILD.gn
@@ -419,7 +419,10 @@ # Only win32 app needs to link with user32.lib # In UWP, all availiable APIs are defined in WindowsApp.lib if (is_win && !dawn_is_winuwp) { - libs += [ "user32.lib" ] + libs += [ + "user32.lib", + "delayimp.lib", + ] public_configs = [ ":win_delayload" ] }