commit b053acf796c27eb4738c966db4a52c8d14bffdad
author Ben Clayton <bclayton@google.com> Mon Nov 16 16:31:07 2020 +0000
committer Commit Bot service account <commit-bot@chromium.org> Mon Nov 16 16:31:07 2020 +0000
tree c45aed9806e7afd09ee55ad03757e4276849051c
parent 0613890eedd7e0226d917e8e5a2a660cd36de0ec

Replace use of std::unique_ptr<T> with T* for AST nodes

This is a minimal effort to fix up the code. There's substantial code
cleanup which can now be done, which is done in the next change.

Bug: tint:322
Change-Id: Iafcf5e814837d9534889e8c21333de4931a19cfa
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32864
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>

src/ast/variable_decl_statement_test.cc

diff --git a/src/ast/variable_decl_statement_test.cc b/src/ast/variable_decl_statement_test.cc
index b32e2c1..9ab2c3b 100644
--- a/src/ast/variable_decl_statement_test.cc
+++ b/src/ast/variable_decl_statement_test.cc
@@ -26,8 +26,8 @@
 
 TEST_F(VariableDeclStatementTest, Creation) {
   type::F32Type f32;
-  auto var = create<Variable>("a", StorageClass::kNone, &f32);
-  auto* var_ptr = var.get();
+  auto* var = create<Variable>("a", StorageClass::kNone, &f32);
+  auto* var_ptr = var;
 
   VariableDeclStatement stmt(std::move(var));
   EXPECT_EQ(stmt.variable(), var_ptr);
@@ -35,7 +35,7 @@
 
 TEST_F(VariableDeclStatementTest, Creation_WithSource) {
   type::F32Type f32;
-  auto var = create<Variable>("a", StorageClass::kNone, &f32);
+  auto* var = create<Variable>("a", StorageClass::kNone, &f32);
 
   VariableDeclStatement stmt(Source{Source::Location{20, 2}}, std::move(var));
   auto src = stmt.source();
@@ -50,14 +50,14 @@
 
 TEST_F(VariableDeclStatementTest, IsValid) {
   type::F32Type f32;
-  auto var = create<Variable>("a", StorageClass::kNone, &f32);
+  auto* var = create<Variable>("a", StorageClass::kNone, &f32);
   VariableDeclStatement stmt(std::move(var));
   EXPECT_TRUE(stmt.IsValid());
 }
 
 TEST_F(VariableDeclStatementTest, IsValid_InvalidVariable) {
   type::F32Type f32;
-  auto var = create<Variable>("", StorageClass::kNone, &f32);
+  auto* var = create<Variable>("", StorageClass::kNone, &f32);
   VariableDeclStatement stmt(std::move(var));
   EXPECT_FALSE(stmt.IsValid());
 }
@@ -69,7 +69,7 @@
 
 TEST_F(VariableDeclStatementTest, ToStr) {
   type::F32Type f32;
-  auto var = create<Variable>("a", StorageClass::kNone, &f32);
+  auto* var = create<Variable>("a", StorageClass::kNone, &f32);
 
   VariableDeclStatement stmt(Source{Source::Location{20, 2}}, std::move(var));
   std::ostringstream out;