commit b1c19eeb4f508d46579aa9e2caf21dcd16d7b12a
author Corentin Wallez <cwallez@chromium.org> Fri Jun 09 10:51:29 2017 -0400
committer Corentin Wallez <corentin@wallez.net> Tue Jun 13 08:30:01 2017 -0700
tree 460939b92e2f37c53b87a536ae9ef7c843121ca4
parent f45bdb89c62845dfb7e65e2e34051b032c31d22d

Add Buffer::MapReadAsync state-tracking

src/backend/common/Buffer.cpp

diff --git a/src/backend/common/Buffer.cpp b/src/backend/common/Buffer.cpp
index b1240f2..8821e5c 100644
--- a/src/backend/common/Buffer.cpp
+++ b/src/backend/common/Buffer.cpp
@@ -30,6 +30,12 @@
           currentUsage(builder->currentUsage) {
     }
 
+    BufferBase::~BufferBase() {
+        if (mapped) {
+            CallMapReadCallback(mapReadSerial, NXT_BUFFER_MAP_READ_STATUS_UNKNOWN, nullptr);
+        }
+    }
+
     BufferViewBuilder* BufferBase::CreateBufferViewBuilder() {
         return new BufferViewBuilder(device, this);
     }
@@ -50,6 +56,13 @@
         return currentUsage;
     }
 
+    void BufferBase::CallMapReadCallback(uint32_t serial, nxtBufferMapReadStatus status, const void* pointer) {
+        if (mapReadCallback && serial == mapReadSerial) {
+            mapReadCallback(status, pointer, mapReadUserdata);
+            mapReadCallback = nullptr;
+        }
+    }
+
     void BufferBase::SetSubData(uint32_t start, uint32_t count, const uint32_t* data) {
         if ((start + count) * sizeof(uint32_t) > GetSize()) {
             device->HandleError("Buffer subdata out of range");
@@ -64,6 +77,46 @@
         SetSubDataImpl(start, count, data);
     }
 
+    void BufferBase::MapReadAsync(uint32_t start, uint32_t size, nxtBufferMapReadCallback callback, nxtCallbackUserdata userdata) {
+        if (start + size > GetSize()) {
+            device->HandleError("Buffer map read out of range");
+            callback(NXT_BUFFER_MAP_READ_STATUS_ERROR, nullptr, userdata);
+            return;
+        }
+
+        if (!(currentUsage & nxt::BufferUsageBit::MapRead)) {
+            device->HandleError("Buffer needs the map read usage bit");
+            callback(NXT_BUFFER_MAP_READ_STATUS_ERROR, nullptr, userdata);
+            return;
+        }
+
+        if (mapped) {
+            device->HandleError("Buffer already mapped");
+            callback(NXT_BUFFER_MAP_READ_STATUS_ERROR, nullptr, userdata);
+            return;
+        }
+
+        // TODO(cwallez@chromium.org): what to do on wraparound? Could cause crashes.
+        mapReadSerial ++;
+        mapReadCallback = callback;
+        mapReadUserdata = userdata;
+        MapReadAsyncImpl(mapReadSerial, start, size);
+        mapped = true;
+    }
+
+    void BufferBase::Unmap() {
+        if (!mapped) {
+            device->HandleError("Buffer wasn't mapped");
+            return;
+        }
+
+        // A map request can only be called once, so this will fire only if the request wasn't
+        // completed before the Unmap
+        CallMapReadCallback(mapReadSerial, NXT_BUFFER_MAP_READ_STATUS_UNKNOWN, nullptr);
+        UnmapImpl();
+        mapped = false;
+    }
+
     bool BufferBase::IsFrozen() const {
         return frozen;
     }
@@ -86,7 +139,7 @@
     }
 
     bool BufferBase::IsTransitionPossible(nxt::BufferUsageBit usage) const {
-        if (frozen) {
+        if (frozen || mapped) {
             return false;
         }
         return IsUsagePossible(allowedUsage, usage);
@@ -138,6 +191,7 @@
             return nullptr;
         }
 
+        // TODO(cwallez@chromium.org) disallow using MapRead with anything else than TransferDst
         return device->CreateBuffer(this);
     }