Remove lintcpp from presubmits since it fails on all Dawn files
Also fixes some other lint issues.
Bug: dawn:1339
Change-Id: I19a212218db3249191deedc671fc6e36991ecad8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86061
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
diff --git a/BUILD.gn b/BUILD.gn
index c33776d..ece3cf7 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -21,8 +21,8 @@
"src/dawn/native:webgpu_dawn",
"src/dawn/tests",
"src/fuzzers/dawn:dawn_fuzzers",
- "src/tint/fuzzers",
"src/tint:libtint",
+ "src/tint/fuzzers",
"test/tint:tint_unittests",
]
if (dawn_standalone) {
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 968a27c..57ddde0 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -129,10 +129,8 @@
input_api, output_api))
results.extend(
input_api.canned_checks.CheckDoNotSubmit(input_api, output_api))
- results.extend(
- input_api.canned_checks.CheckChangeLintsClean(input_api,
- output_api,
- lint_filters=""))
+ # TODO(dawn:1339): Add back CheckChangeLintsClean, it fails on all Dawn
+ # source files because they where never linted (and use different rules).
results.extend(
_CheckNonInclusiveLanguage(input_api, output_api,
_NonInclusiveFileFilter))
diff --git a/src/dawn/native/BUILD.gn b/src/dawn/native/BUILD.gn
index 5d97a8e..4547138 100644
--- a/src/dawn/native/BUILD.gn
+++ b/src/dawn/native/BUILD.gn
@@ -161,9 +161,9 @@
":headers",
":utils_gen",
"${dawn_root}/src/dawn/common",
+ "${dawn_root}/src/tint:libtint",
"${dawn_spirv_tools_dir}:spvtools_opt",
"${dawn_spirv_tools_dir}:spvtools_val",
- "${dawn_root}/src/tint:libtint",
]
defines = []
libs = []
diff --git a/src/dawn/tests/unittests/ITypBitsetTests.cpp b/src/dawn/tests/unittests/ITypBitsetTests.cpp
index 6aa7fd2..ea4d059 100644
--- a/src/dawn/tests/unittests/ITypBitsetTests.cpp
+++ b/src/dawn/tests/unittests/ITypBitsetTests.cpp
@@ -206,4 +206,4 @@
EXPECT_EQ(36u, static_cast<size_t>(GetHighestBitIndexPlusOne(Bitset40(0xFFFFFFFFF))));
EXPECT_EQ(40u, static_cast<size_t>(GetHighestBitIndexPlusOne(Bitset40(0xF000000000))));
EXPECT_EQ(40u, static_cast<size_t>(GetHighestBitIndexPlusOne(Bitset40(0xFFFFFFFFFF))));
-}
\ No newline at end of file
+}
diff --git a/src/dawn/tests/white_box/D3D12GPUTimestampCalibrationTests.cpp b/src/dawn/tests/white_box/D3D12GPUTimestampCalibrationTests.cpp
index bff420f..465bcd0 100644
--- a/src/dawn/tests/white_box/D3D12GPUTimestampCalibrationTests.cpp
+++ b/src/dawn/tests/white_box/D3D12GPUTimestampCalibrationTests.cpp
@@ -115,4 +115,4 @@
}
DAWN_INSTANTIATE_TEST(D3D12GPUTimestampCalibrationTests,
- D3D12Backend({"disable_timestamp_query_conversion"}));
\ No newline at end of file
+ D3D12Backend({"disable_timestamp_query_conversion"}));
diff --git a/src/tint/BUILD.gn b/src/tint/BUILD.gn
index 58ec6a4..1a4ae17 100644
--- a/src/tint/BUILD.gn
+++ b/src/tint/BUILD.gn
@@ -449,6 +449,8 @@
"transform/decompose_strided_array.h",
"transform/decompose_strided_matrix.cc",
"transform/decompose_strided_matrix.h",
+ "transform/expand_compound_assignment.cc",
+ "transform/expand_compound_assignment.h",
"transform/first_index_offset.cc",
"transform/first_index_offset.h",
"transform/fold_constants.cc",
@@ -457,8 +459,6 @@
"transform/fold_trivial_single_use_lets.h",
"transform/for_loop_to_loop.cc",
"transform/for_loop_to_loop.h",
- "transform/expand_compound_assignment.cc",
- "transform/expand_compound_assignment.h",
"transform/localize_struct_array_assignment.cc",
"transform/localize_struct_array_assignment.h",
"transform/loop_to_for_loop.cc",
diff --git a/test/tint/BUILD.gn b/test/tint/BUILD.gn
index 2839ae6..c5e8048 100644
--- a/test/tint/BUILD.gn
+++ b/test/tint/BUILD.gn
@@ -320,11 +320,11 @@
"../../src/tint/transform/decompose_memory_access_test.cc",
"../../src/tint/transform/decompose_strided_array_test.cc",
"../../src/tint/transform/decompose_strided_matrix_test.cc",
+ "../../src/tint/transform/expand_compound_assignment_test.cc",
"../../src/tint/transform/first_index_offset_test.cc",
"../../src/tint/transform/fold_constants_test.cc",
"../../src/tint/transform/fold_trivial_single_use_lets_test.cc",
"../../src/tint/transform/for_loop_to_loop_test.cc",
- "../../src/tint/transform/expand_compound_assignment_test.cc",
"../../src/tint/transform/localize_struct_array_assignment_test.cc",
"../../src/tint/transform/loop_to_for_loop_test.cc",
"../../src/tint/transform/module_scope_var_to_entry_point_param_test.cc",
