[tint][fuzz][ast] Add BindingRemapper fuzzer
Bug: tint:2223
Change-Id: Ic8aa1ecf7ecb6a81c9b7640de13f56399e0fc010
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/185624
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
diff --git a/src/tint/lang/wgsl/ast/transform/BUILD.cmake b/src/tint/lang/wgsl/ast/transform/BUILD.cmake
index 13dc91b..2af7445 100644
--- a/src/tint/lang/wgsl/ast/transform/BUILD.cmake
+++ b/src/tint/lang/wgsl/ast/transform/BUILD.cmake
@@ -251,6 +251,7 @@
lang/wgsl/ast/transform/add_block_attribute_fuzz.cc
lang/wgsl/ast/transform/add_empty_entry_point_fuzz.cc
lang/wgsl/ast/transform/array_length_from_uniform_fuzz.cc
+ lang/wgsl/ast/transform/binding_remapper_fuzz.cc
lang/wgsl/ast/transform/zero_init_workgroup_memory_fuzz.cc
)
diff --git a/src/tint/lang/wgsl/ast/transform/BUILD.gn b/src/tint/lang/wgsl/ast/transform/BUILD.gn
index 63bcb03..cd2581a 100644
--- a/src/tint/lang/wgsl/ast/transform/BUILD.gn
+++ b/src/tint/lang/wgsl/ast/transform/BUILD.gn
@@ -241,6 +241,7 @@
"add_block_attribute_fuzz.cc",
"add_empty_entry_point_fuzz.cc",
"array_length_from_uniform_fuzz.cc",
+ "binding_remapper_fuzz.cc",
"zero_init_workgroup_memory_fuzz.cc",
]
deps = [
diff --git a/src/tint/lang/wgsl/ast/transform/binding_remapper.cc b/src/tint/lang/wgsl/ast/transform/binding_remapper.cc
index 31ef518..5501dd5 100644
--- a/src/tint/lang/wgsl/ast/transform/binding_remapper.cc
+++ b/src/tint/lang/wgsl/ast/transform/binding_remapper.cc
@@ -47,6 +47,7 @@
namespace tint::ast::transform {
+BindingRemapper::Remappings::Remappings() = default;
BindingRemapper::Remappings::Remappings(BindingPoints bp, AccessControls ac, bool may_collide)
: binding_points(std::move(bp)),
access_controls(std::move(ac)),
diff --git a/src/tint/lang/wgsl/ast/transform/binding_remapper.h b/src/tint/lang/wgsl/ast/transform/binding_remapper.h
index a21a090..ff8785d 100644
--- a/src/tint/lang/wgsl/ast/transform/binding_remapper.h
+++ b/src/tint/lang/wgsl/ast/transform/binding_remapper.h
@@ -33,6 +33,7 @@
#include "src/tint/api/common/binding_point.h"
#include "src/tint/lang/core/access.h"
#include "src/tint/lang/wgsl/ast/transform/transform.h"
+#include "src/tint/utils/reflection/reflection.h"
namespace tint::ast::transform {
@@ -53,6 +54,9 @@
/// Data holds information about shader usage and constant buffer offsets.
struct Remappings final : public Castable<Remappings, Data> {
/// Constructor
+ Remappings();
+
+ /// Constructor
/// @param bp a map of new binding points
/// @param ac a map of new access controls
/// @param may_collide If true, then validation will be disabled for
@@ -66,14 +70,17 @@
~Remappings() override;
/// A map of old binding point to new binding point
- const BindingPoints binding_points;
+ BindingPoints binding_points;
/// A map of old binding point to new access controls
- const AccessControls access_controls;
+ AccessControls access_controls;
/// If true, then validation will be disabled for binding point collisions
/// generated by this transform
- const bool allow_collisions;
+ bool allow_collisions = false;
+
+ /// Reflection for this class
+ TINT_REFLECT(Remappings, binding_points, access_controls, allow_collisions);
};
/// Constructor
diff --git a/src/tint/lang/wgsl/ast/transform/binding_remapper_fuzz.cc b/src/tint/lang/wgsl/ast/transform/binding_remapper_fuzz.cc
new file mode 100644
index 0000000..2f27549
--- /dev/null
+++ b/src/tint/lang/wgsl/ast/transform/binding_remapper_fuzz.cc
@@ -0,0 +1,89 @@
+// Copyright 2024 The Dawn & Tint Authors
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are met:
+//
+// 1. Redistributions of source code must retain the above copyright notice, this
+// list of conditions and the following disclaimer.
+//
+// 2. Redistributions in binary form must reproduce the above copyright notice,
+// this list of conditions and the following disclaimer in the documentation
+// and/or other materials provided with the distribution.
+//
+// 3. Neither the name of the copyright holder nor the names of its
+// contributors may be used to endorse or promote products derived from
+// this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+// OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+#include "src/tint/api/common/binding_point.h"
+#include "src/tint/cmd/fuzz/wgsl/fuzz.h"
+#include "src/tint/lang/core/access.h"
+#include "src/tint/lang/wgsl/ast/module.h"
+#include "src/tint/lang/wgsl/ast/transform/binding_remapper.h"
+#include "src/tint/lang/wgsl/sem/variable.h"
+
+namespace tint::ast::transform {
+namespace {
+
+bool CanRun(const Program& program, const BindingRemapper::Remappings& remappings) {
+ if (!remappings.access_controls.empty()) {
+ // Changing access is likely to cause WGSL validation failures. Just skip these for now.
+ return false;
+ }
+
+ if (!remappings.allow_collisions) {
+ Hashset<BindingPoint, 8> binding_points;
+ for (auto* global : program.AST().GlobalVariables()) {
+ if (auto* sem = program.Sem().Get<sem::GlobalVariable>(global)) {
+ if (auto binding_point = sem->Attributes().binding_point) {
+ binding_points.Add(binding_point.value());
+ }
+ }
+ }
+ Hashset<BindingPoint, 8> new_binding_points;
+ for (auto& remapping : remappings.binding_points) {
+ if (binding_points.Remove(remapping.first)) {
+ if (!new_binding_points.Add(remapping.second)) {
+ return false; // Binding collision
+ }
+ }
+ }
+ for (auto& binding_point : new_binding_points) {
+ if (!binding_points.Add(binding_point)) {
+ return false; // Binding collision
+ }
+ }
+ }
+ return true;
+}
+
+void BindingRemapperFuzzer(const Program& program, const BindingRemapper::Remappings& remappings) {
+ if (!CanRun(program, remappings)) {
+ return;
+ }
+
+ DataMap inputs;
+ inputs.Add<BindingRemapper::Remappings>(std::move(remappings));
+
+ DataMap outputs;
+ if (auto result = BindingRemapper{}.Apply(program, inputs, outputs)) {
+ if (!result->IsValid()) {
+ TINT_ICE() << "BindingRemapper returned invalid program:\n" << result->Diagnostics();
+ }
+ }
+}
+
+} // namespace
+} // namespace tint::ast::transform
+
+TINT_WGSL_PROGRAM_FUZZER(tint::ast::transform::BindingRemapperFuzzer);
