commit b3b87054079f27e9d8ec304c1d9836e0ca8c84c7
author Ben Clayton <bclayton@google.com> Wed Dec 06 14:29:04 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Dec 06 14:29:04 2023 +0000
tree e524c27836e1256f06e300bd187c957f876163dd
parent 5cb7fd5a47de28c3f8bc3b8afe289265801d9745

[tools] Fix term.CanUseAnsiEscapeSequences()

OR should have been AND

Change-Id: I975e686db39c606f429ee73b20fa1ffc84c5059c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/164665
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

tools/src/term/ansi_esc.go

diff --git a/tools/src/term/ansi_esc.go b/tools/src/term/ansi_esc.go
index 810118a..63a745f 100644
--- a/tools/src/term/ansi_esc.go
+++ b/tools/src/term/ansi_esc.go
@@ -55,9 +55,9 @@
 // CanUseAnsiEscapeSequences looks at the process's environment to determine
 // whether its sensible to emit ansi-escape sequences.
 func CanUseAnsiEscapeSequences() bool {
-	if os.Getenv("TERM") != "dumb" ||
-		(isatty.IsTerminal(os.Stdout.Fd()) && isatty.IsTerminal(os.Stderr.Fd())) ||
-		(isatty.IsCygwinTerminal(os.Stdout.Fd()) && isatty.IsCygwinTerminal(os.Stderr.Fd())) {
+	if os.Getenv("TERM") != "dumb" &&
+		((isatty.IsTerminal(os.Stdout.Fd()) && isatty.IsTerminal(os.Stderr.Fd())) ||
+			(isatty.IsCygwinTerminal(os.Stdout.Fd()) && isatty.IsCygwinTerminal(os.Stderr.Fd()))) {
 		if _, disable := os.LookupEnv("NO_COLOR"); !disable {
 			return true
 		}