commit b61e3b09f4963925a8fb7a7a513b11991975a294
author François Beaufort <beaufort.francois@gmail.com> Wed Nov 08 18:08:01 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Nov 08 18:08:01 2023 +0000
tree fdb5e879e76561fc6d749a940ed8fbc77d02dd87
parent b0e405493ad845e2d91d1e1487271bc490d469d3

Make timestamp-query feature stable

This CL make timestamp-query feature from experimental to stable so
that it is exposed without allow_unsafe_apis toggle.

Bug: dawn:1800
Change-Id: I70a0620ec58f89794906959d6513979f27922682
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/158060
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>

src/dawn/native/Features.cpp

diff --git a/src/dawn/native/Features.cpp b/src/dawn/native/Features.cpp
index c098b5e..664cecc 100644
--- a/src/dawn/native/Features.cpp
+++ b/src/dawn/native/Features.cpp
@@ -61,7 +61,7 @@
       "https://bugs.chromium.org/p/dawn/issues/detail?id=955", FeatureInfo::FeatureState::Stable}},
     {Feature::TimestampQuery,
      {"Support Timestamp Query", "https://bugs.chromium.org/p/dawn/issues/detail?id=434",
-      FeatureInfo::FeatureState::Experimental}},
+      FeatureInfo::FeatureState::Stable}},
     {Feature::ChromiumExperimentalTimestampQueryInsidePasses,
      {"Support experimental Timestamp Query inside render/compute pass",
       "https://bugs.chromium.org/p/dawn/issues/detail?id=434",

src/dawn/native/QuerySet.cpp

diff --git a/src/dawn/native/QuerySet.cpp b/src/dawn/native/QuerySet.cpp
index d5d6b03..aa2bab4 100644
--- a/src/dawn/native/QuerySet.cpp
+++ b/src/dawn/native/QuerySet.cpp
@@ -63,10 +63,6 @@
             break;
 
         case wgpu::QueryType::Timestamp:
-            DAWN_INVALID_IF(!device->IsToggleEnabled(Toggle::AllowUnsafeAPIs),
-                            "Timestamp queries are disallowed because they may expose precise "
-                            "timing information.");
-
             DAWN_INVALID_IF(
                 !device->HasFeature(Feature::TimestampQuery) &&
                     !device->HasFeature(Feature::ChromiumExperimentalTimestampQueryInsidePasses),