commit b6f45484545f685dca85cad9b18dd8f0953840eb
author Ben Clayton <bclayton@google.com> Tue Sep 05 13:09:42 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 05 13:09:42 2023 +0000
tree 37cecb4781bb1bb6943b7c360fb018a4ae7f0ced
parent b6ef5273e530e6186ce6545551ae79d65d4fcbc8

[tint][utils] Remove pointless nullptr check in vector Free()

delete already handles nullptr

Change-Id: I7733315f08ccd30c53d0d46011f392587259b9fd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/149685
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>

src/tint/utils/containers/vector.h

diff --git a/src/tint/utils/containers/vector.h b/src/tint/utils/containers/vector.h
index 4f38c32..e2e4f67 100644
--- a/src/tint/utils/containers/vector.h
+++ b/src/tint/utils/containers/vector.h
@@ -558,9 +558,9 @@
             }
         }
 
-        /// Frees `data`, if not nullptr and isn't a pointer to #small_arr
+        /// Frees `data`, if isn't a pointer to #small_arr
         void Free(T* data) const {
-            if (data && data != small_arr[0].Get()) {
+            if (data != small_arr[0].Get()) {
                 delete[] Bitcast<TStorage*>(data);
             }
         }
@@ -580,12 +580,8 @@
             slice.cap = new_cap;
         }
 
-        /// Frees `data`, if not nullptr.
-        void Free(T* data) const {
-            if (data) {
-                delete[] Bitcast<TStorage*>(data);
-            }
-        }
+        /// Frees `data`.
+        void Free(T* data) const { delete[] Bitcast<TStorage*>(data); }
 
         /// Indicates whether the slice structure can be std::move()d.
         /// @returns true