Implement internal storage for buffer usage and buffer binding type
In the timestamp internal pipeline, the ResolveQuery buffer cannnot be
binded as Storage buffer in binding group layout due to it has not
Storage usage.
Add InternalStorageBuffer for buffer usage and
InternalStorageBufferBinding for buffer binding type, make the
QueryResolve buffer implicitly get InternalStorageBuffer and only
compatible with InternalStorageBufferBinding in BGL, not Storage buffer
binding type.
Bug: dawn:797
Change-Id: I286339e703e26d3786c706ded03f850ca17355fb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/54400
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Commit-Queue: Hao Li <hao.x.li@intel.com>
diff --git a/src/dawn_native/Buffer.cpp b/src/dawn_native/Buffer.cpp
index cdd9f05..56c6ea6 100644
--- a/src/dawn_native/Buffer.cpp
+++ b/src/dawn_native/Buffer.cpp
@@ -138,12 +138,11 @@
mUsage |= kReadOnlyStorageBuffer;
}
- // TODO(crbug.com/dawn/434): This is just a workaround to make QueryResolve buffer pass the
- // binding group validation when used as an internal resource. Instead the buffer made with
- // QueryResolve usage would implicitly get StorageInternal usage which is only compatible
- // with StorageBufferInternal binding type in BGL, not StorageBuffer binding type.
+ // The buffer made with QueryResolve usage implicitly get InternalStorage usage which is
+ // only compatible with InternalStorageBuffer binding type in BGL, not StorageBuffer binding
+ // type.
if (mUsage & wgpu::BufferUsage::QueryResolve) {
- mUsage |= wgpu::BufferUsage::Storage;
+ mUsage |= kInternalStorageBuffer;
}
}
