commit be6b4f8e2175da646966745a6cc1f94de92ad512
author Shrek Shao <shrekshao@google.com> Wed Mar 05 01:27:16 2025 -0800
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Mar 05 01:27:16 2025 -0800
tree 6b1b5f0fc0b55c68c6fe967ca3a52e75cc99a8ea
parent 15d27d3399af09bbe8092d1ba7ba4d2ee866e8fc

Remove enabling core-features-and-limits in backends

Checking if support core level and enable the feature
is already done in the frontend.

Bug: 395855517
Change-Id: I04782eb289c7bb538054c9e881be4ef7e2795e62
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/228954
Auto-Submit: Shrek Shao <shrekshao@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

src/dawn/native/d3d11/PhysicalDeviceD3D11.cpp

diff --git a/src/dawn/native/d3d11/PhysicalDeviceD3D11.cpp b/src/dawn/native/d3d11/PhysicalDeviceD3D11.cpp
index 0b23de8..82661db 100644
--- a/src/dawn/native/d3d11/PhysicalDeviceD3D11.cpp
+++ b/src/dawn/native/d3d11/PhysicalDeviceD3D11.cpp
@@ -146,9 +146,6 @@
 }
 
 void PhysicalDevice::InitializeSupportedFeaturesImpl() {
-    if (SupportsFeatureLevel(wgpu::FeatureLevel::Core, nullptr)) {
-        EnableFeature(Feature::CoreFeaturesAndLimits);
-    }
     EnableFeature(Feature::Depth32FloatStencil8);
     EnableFeature(Feature::DepthClipControl);
     EnableFeature(Feature::TextureCompressionBC);

src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp

diff --git a/src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp b/src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp
index 48d70b0..2558d61 100644
--- a/src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp
+++ b/src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp
@@ -145,7 +145,6 @@
 }
 
 void PhysicalDevice::InitializeSupportedFeaturesImpl() {
-    EnableFeature(Feature::CoreFeaturesAndLimits);
     EnableFeature(Feature::TextureCompressionBC);
     EnableFeature(Feature::DawnMultiPlanarFormats);
     EnableFeature(Feature::Depth32FloatStencil8);

src/dawn/native/metal/PhysicalDeviceMTL.mm

diff --git a/src/dawn/native/metal/PhysicalDeviceMTL.mm b/src/dawn/native/metal/PhysicalDeviceMTL.mm
index b66e084..be6834b 100644
--- a/src/dawn/native/metal/PhysicalDeviceMTL.mm
+++ b/src/dawn/native/metal/PhysicalDeviceMTL.mm
@@ -539,8 +539,6 @@
 }
 
 void PhysicalDevice::InitializeSupportedFeaturesImpl() {
-    EnableFeature(Feature::CoreFeaturesAndLimits);
-
 #if (defined(__MAC_11_0) && __MAC_OS_X_VERSION_MIN_REQUIRED >= __MAC_11_0) || \
     (defined(__IPHONE_14_0) && __IPHONE_OS_VERSION_MIN_REQUIRED >= __IPHONE_14_0)
     if ([*mDevice supports32BitFloatFiltering]) {

src/dawn/native/vulkan/PhysicalDeviceVk.cpp

diff --git a/src/dawn/native/vulkan/PhysicalDeviceVk.cpp b/src/dawn/native/vulkan/PhysicalDeviceVk.cpp
index 90a5d0d..798c15c 100644
--- a/src/dawn/native/vulkan/PhysicalDeviceVk.cpp
+++ b/src/dawn/native/vulkan/PhysicalDeviceVk.cpp
@@ -219,9 +219,6 @@
 }
 
 void PhysicalDevice::InitializeSupportedFeaturesImpl() {
-    if (SupportsFeatureLevel(wgpu::FeatureLevel::Core, nullptr)) {
-        EnableFeature(Feature::CoreFeaturesAndLimits);
-    }
     EnableFeature(Feature::AdapterPropertiesMemoryHeaps);
     EnableFeature(Feature::StaticSamplers);
     EnableFeature(Feature::FlexibleTextureViews);