commit c1f51124621275ffddf6bb55196755ce4ed3567e
author Austin Eng <enga@chromium.org> Mon Sep 12 21:43:21 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 12 21:43:21 2022 +0000
tree 90f4334b3ef6982132c148136376ea32799f9c5b
parent 54bee2372f32a6a3b1f1228327d7aa46c1dfd240

Remove code to set Vulkan backend debug labels

This is hitting a memory corruption issue inside the NVIDIA driver.
Speculatively delete the code in the Vulkan backend until further
analysis finds the root cause.

Bug: dawn:1539
Change-Id: Ie7bf5bed31976da5f13325c81033e787c4d376b9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102100
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>

src/dawn/native/vulkan/UtilsVulkan.cpp

diff --git a/src/dawn/native/vulkan/UtilsVulkan.cpp b/src/dawn/native/vulkan/UtilsVulkan.cpp
index aa02ec3..b1ab45c 100644
--- a/src/dawn/native/vulkan/UtilsVulkan.cpp
+++ b/src/dawn/native/vulkan/UtilsVulkan.cpp
@@ -209,28 +209,7 @@
                           uint64_t objectHandle,
                           const char* prefix,
                           std::string label) {
-    if (!objectHandle) {
-        return;
-    }
-
-    if (device->GetGlobalInfo().HasExt(InstanceExt::DebugUtils)) {
-        VkDebugUtilsObjectNameInfoEXT objectNameInfo;
-        objectNameInfo.sType = VK_STRUCTURE_TYPE_DEBUG_UTILS_OBJECT_NAME_INFO_EXT;
-        objectNameInfo.pNext = nullptr;
-        objectNameInfo.objectType = objectType;
-        objectNameInfo.objectHandle = objectHandle;
-
-        std::ostringstream objectNameStream;
-        // Prefix with the device's message ID so that if this label appears in a validation
-        // message it can be parsed out and the message can be associated with the right device.
-        objectNameStream << device->GetDebugPrefix() << kDeviceDebugSeparator << prefix;
-        if (!label.empty() && device->IsToggleEnabled(Toggle::UseUserDefinedLabelsInBackend)) {
-            objectNameStream << "_" << label;
-        }
-        std::string objectName = objectNameStream.str();
-        objectNameInfo.pObjectName = objectName.c_str();
-        device->fn.SetDebugUtilsObjectNameEXT(device->GetVkDevice(), &objectNameInfo);
-    }
+    // Implementation removed due to crbug.com/dawn/1539.
 }
 
 std::string GetNextDeviceDebugPrefix() {