commit c1fd6316de4817f1d1a5caef97a5623e384e472c
author James Price <jrprice@google.com> Wed May 24 16:55:30 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 24 16:55:30 2023 +0000
tree 7008a2e7cc3ab7c9526a27ada3c285b7cbe5a971
parent c9c19c49f9aee870c561eb60ef93791743fed41c

[fuzzers] Substitute all override variables

The transform was only being run if there was at least one override
without an initializer. We actually need to run the transform if there
are any overrides at all, even if they all have initializers.

Bug: chromium:1447418
Change-Id: Ia300ea4326b675c1fd84dd7709112fb69128963d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134203
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: James Price <jrprice@google.com>

src/tint/fuzzers/tint_common_fuzzer.cc

diff --git a/src/tint/fuzzers/tint_common_fuzzer.cc b/src/tint/fuzzers/tint_common_fuzzer.cc
index 5595d10..6fa3b6e 100644
--- a/src/tint/fuzzers/tint_common_fuzzer.cc
+++ b/src/tint/fuzzers/tint_common_fuzzer.cc
@@ -248,7 +248,7 @@
             cfg.map.insert({override_id, 0.0});
         }
 
-        if (!cfg.map.empty()) {
+        if (!default_values.empty()) {
             transform::DataMap override_data;
             override_data.Add<ast::transform::SubstituteOverride::Config>(cfg);