commit c3a2680a91a288f301559ea37043287073bef669
author Jiawei Shao <jiawei.shao@intel.com> Thu May 16 01:08:32 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 16 01:08:32 2024 +0000
tree cf23ce87f965be7fb7abb717ef7d40e15657558a
parent 8c6c80307665afe6df3c9c0d7b504c5a5fb7c984

Reland "Remove deprecated `APIReference()`"

This reverts commit f72e01bbe9737722310e7c656e7f95d0515c936c.

Reason for revert: All the `APIReference()` calls have been removed
from Chromium.

Original change's description:
> Revert "Remove deprecated `APIReference()`"
>
> This reverts commit cbe795822ae42b4b8751f377fe6e9044ad12dd7e.
>
> Reason for revert: dawn into chromium auto roller is broken
> https://ci.chromium.org/ui/p/chromium/builders/try/android-arm64-rel/587482/overview
>
> Original change's description:
> > Remove deprecated `APIReference()`
> >
> > This patch removes the deprecated API `APIReference()` from Dawn.
> >
> > Bug: dawn:2234
> > Change-Id: I238f65c5e49d0abd04ee9c66bb0c0c52e73822ea
> > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/187707
> > Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> > Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
>
> TBR=cwallez@chromium.org,jiawei.shao@intel.com,enga@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lokokung@google.com
>
> Change-Id: Iefe18730f866d30f61d13eda77a8cb42319cf2df
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: dawn:2234
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/188060
> Auto-Submit: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Loko Kung <lokokung@google.com>
> Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: dawn:2234
Change-Id: I45afe25b974aa4b10a34dca736b754a0643cdedc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/188380
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

generator/dawn_json_generator.py

diff --git a/generator/dawn_json_generator.py b/generator/dawn_json_generator.py
index 8da2fb0..a5b9b7e 100644
--- a/generator/dawn_json_generator.py
+++ b/generator/dawn_json_generator.py
@@ -964,8 +964,6 @@
 
 def c_methods(params, typ):
     return typ.methods + [
-        # TODO(dawn:2234): Deprecated. Remove when no longer used.
-        Method(Name('reference'), params['types']['void'], [], False, {}),
         Method(Name('add ref'), params['types']['void'], [], False, {}),
         Method(Name('release'), params['types']['void'], [], False, {}),
     ]

generator/templates/api.h

diff --git a/generator/templates/api.h b/generator/templates/api.h
index 43b495e..80d4991 100644
--- a/generator/templates/api.h
+++ b/generator/templates/api.h
@@ -73,8 +73,6 @@
 #include <stdint.h>
 #include <stddef.h>
 
-#define WGPU_BREAKING_REFERENCE_ADDREF
-
 #if defined(__cplusplus)
 #  if __cplusplus >= 201103L
 #    define {{API}}_MAKE_INIT_STRUCT(type, value) (type value)

src/dawn/common/RefCounted.h

diff --git a/src/dawn/common/RefCounted.h b/src/dawn/common/RefCounted.h
index 0d06e04..cf062d2 100644
--- a/src/dawn/common/RefCounted.h
+++ b/src/dawn/common/RefCounted.h
@@ -76,8 +76,6 @@
     // synchronization in place for destruction.
     void Release();
 
-    // TODO(dawn:2234): Deprecated. Remove when no longer used.
-    void APIReference() { APIAddRef(); }
     void APIAddRef() { AddRef(); }
     void APIRelease() { Release(); }
 

src/dawn/fuzzers/DawnWireServerFuzzer.cpp

diff --git a/src/dawn/fuzzers/DawnWireServerFuzzer.cpp b/src/dawn/fuzzers/DawnWireServerFuzzer.cpp
index 3797267..5512b5d 100644
--- a/src/dawn/fuzzers/DawnWireServerFuzzer.cpp
+++ b/src/dawn/fuzzers/DawnWireServerFuzzer.cpp
@@ -120,7 +120,7 @@
         for (dawn::native::Adapter adapter : adapters) {
             if (sAdapterSupported(adapter)) {
                 WGPUAdapter cAdapter = adapter.Get();
-                dawn::native::GetProcs().adapterReference(cAdapter);
+                dawn::native::GetProcs().adapterAddRef(cAdapter);
                 callback(WGPURequestAdapterStatus_Success, cAdapter, nullptr, userdata);
                 return;
             }

src/dawn/native/RefCountedWithExternalCount.h

diff --git a/src/dawn/native/RefCountedWithExternalCount.h b/src/dawn/native/RefCountedWithExternalCount.h
index 64b4e5d..524e988 100644
--- a/src/dawn/native/RefCountedWithExternalCount.h
+++ b/src/dawn/native/RefCountedWithExternalCount.h
@@ -48,8 +48,6 @@
     using T::Release;
     using T::T;
 
-    // TODO(dawn:2234): Deprecated. Remove when no longer used.
-    void APIReference() { APIAddRef(); }
     void APIAddRef() {
         IncrementExternalRefCount();
         T::APIAddRef();
@@ -59,7 +57,7 @@
         if (mExternalRefCount.Decrement()) {
             WillDropLastExternalRef();
         }
-        T::APIRelease();
+        T::Release();
     }
 
     void IncrementExternalRefCount() { mExternalRefCount.Increment(); }