DEPS: Use a pinned version of depot_tools
This has multiple benefits:
- RemoteExec will be able to build cpps remotely that depend on files in
depot_tools (e.g. Windows SDK), otherwise these are always built
locally. This means faster builds on bots as well.
- Will align Dawn's standalone build with Chromium's as they'll use the
same depot_tools version (once we setup an autoroller).
Bug: dawn:2431
Change-Id: I5a820a2a1e418f748b4e3635a86641d1b18c80af
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/175821
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
diff --git a/DEPS b/DEPS
index 0893cb2..c4f46fa 100644
--- a/DEPS
+++ b/DEPS
@@ -94,6 +94,11 @@
'condition': 'dawn_standalone and host_os == "win"',
},
+ 'third_party/depot_tools': {
+ 'url': '{chromium_git}/chromium/tools/depot_tools.git@35a5306635084412e01fa23d64654907f39bc44a',
+ 'condition': 'dawn_standalone',
+ },
+
'third_party/libc++/src': {
'url': '{chromium_git}/external/github.com/llvm/llvm-project/libcxx.git@278060665f956b98b54922e3cb5e38b07884ce7d',
'condition': 'dawn_standalone',
@@ -293,6 +298,19 @@
}
hooks = [
+ {
+ # Ensure that the DEPS'd "depot_tools" has its self-update capability
+ # disabled.
+ 'name': 'disable_depot_tools_selfupdate',
+ 'pattern': '.',
+ 'condition': 'dawn_standalone',
+ 'action': [
+ 'python3',
+ 'third_party/depot_tools/update_depot_tools_toggle.py',
+ '--disable',
+ ],
+ },
+
# Pull the compilers and system libraries for hermetic builds
{
'name': 'sysroot_x86',
@@ -321,7 +339,8 @@
'name': 'ciopfs_linux',
'pattern': '.',
'condition': 'dawn_standalone and checkout_win and host_os == "linux"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--no_auth',
'--bucket', 'chromium-browser-clang/ciopfs',
@@ -362,7 +381,8 @@
'name': 'rc_win',
'pattern': '.',
'condition': 'dawn_standalone and checkout_win and host_os == "win"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--no_auth',
'--bucket', 'chromium-browser-clang/rc',
@@ -373,7 +393,8 @@
'name': 'rc_linux',
'pattern': '.',
'condition': 'dawn_standalone and checkout_win and host_os == "linux"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--no_auth',
'--bucket', 'chromium-browser-clang/rc',
@@ -384,7 +405,8 @@
'name': 'rc_mac',
'pattern': '.',
'condition': 'dawn_standalone and checkout_win and host_os == "mac"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--no_auth',
'--bucket', 'chromium-browser-clang/rc',
@@ -396,7 +418,8 @@
'name': 'clang_format_win',
'pattern': '.',
'condition': 'dawn_standalone and host_os == "win"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--no_auth',
'--bucket', 'chromium-clang-format',
@@ -407,7 +430,8 @@
'name': 'clang_format_mac_x64',
'pattern': '.',
'condition': 'dawn_standalone and host_os == "mac" and host_cpu == "x64"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--no_auth',
'--bucket', 'chromium-clang-format',
@@ -419,7 +443,8 @@
'name': 'clang_format_mac_arm64',
'pattern': '.',
'condition': 'dawn_standalone and host_os == "mac" and host_cpu == "arm64"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--no_auth',
'--bucket', 'chromium-clang-format',
@@ -431,7 +456,8 @@
'name': 'clang_format_linux',
'pattern': '.',
'condition': 'dawn_standalone and host_os == "linux"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--no_auth',
'--bucket', 'chromium-clang-format',
@@ -451,7 +477,8 @@
'name': 'cmake_win32',
'pattern': '.',
'condition': 'dawn_node and host_os == "win"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--platform=win32',
'--no_auth',
@@ -476,7 +503,8 @@
'name': 'node_linux64',
'pattern': '.',
'condition': 'dawn_node and host_os == "linux"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--extract',
'--no_auth',
@@ -489,7 +517,8 @@
'name': 'node_mac',
'pattern': '.',
'condition': 'dawn_node and host_os == "mac"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--extract',
'--no_auth',
@@ -502,7 +531,8 @@
'name': 'node_mac_arm64',
'pattern': '.',
'condition': 'dawn_node and host_os == "mac"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--extract',
'--no_auth',
@@ -515,7 +545,8 @@
'name': 'node_win',
'pattern': '.',
'condition': 'dawn_node and host_os == "win"',
- 'action': [ 'download_from_google_storage',
+ 'action': [ 'python3',
+ 'third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
'--no_auth',
'--bucket', 'chromium-nodejs/20.11.0',
