commit ca41b006917e80081d1392fa53a08dd20cf93e91
author Austin Eng <enga@chromium.org> Mon Jun 07 18:23:52 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 07 18:23:52 2021 +0000
tree 42d69e1692e909fa448ee1849a1438e6cc569a52
parent 9df00a3e9acf79bb12173ff9aab5e738f2f99b04

Triage Dawn TODOs

Change-Id: Ia049d5a03d0e251531f71def525492403588fd74
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/53460
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/utils/TerribleCommandBuffer.cpp

diff --git a/src/utils/TerribleCommandBuffer.cpp b/src/utils/TerribleCommandBuffer.cpp
index c6f1ac3..0c06ab1 100644
--- a/src/utils/TerribleCommandBuffer.cpp
+++ b/src/utils/TerribleCommandBuffer.cpp
@@ -34,9 +34,7 @@
     }
 
     void* TerribleCommandBuffer::GetCmdSpace(size_t size) {
-        // TODO(kainino@chromium.org): Should we early-out if size is 0?
-        //   (Here and/or in the caller?) It might be good to make the wire receiver get a nullptr
-        //   instead of pointer to zero-sized allocation in mBuffer.
+        // Note: This returns non-null even if size is zero.
         if (size > sizeof(mBuffer)) {
             return nullptr;
         }

src/utils/TestUtils.cpp

diff --git a/src/utils/TestUtils.cpp b/src/utils/TestUtils.cpp
index 69b75ca..cac3a1a 100644
--- a/src/utils/TestUtils.cpp
+++ b/src/utils/TestUtils.cpp
@@ -36,7 +36,7 @@
         wgpu::Extent3D textureSizeAtLevel0,
         uint32_t mipmapLevel,
         uint32_t rowsPerImage) {
-        // TODO(jiawei.shao@intel.com): support compressed texture formats
+        // Compressed texture formats not supported in this function yet.
         ASSERT(utils::GetTextureFormatBlockWidth(format) == 1);
 
         TextureDataCopyLayout layout;