commit cac3e7e110bf00b84e0a029464fff6e1b30ba661
author Corentin Wallez <cwallez@chromium.org> Wed Sep 29 09:15:02 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 29 09:15:02 2021 +0000
tree a1ac8e5785e82b57dff1f31e7f8837db758c076c
parent bc207f71937b2bc99d36fbbaa38452c36706f87e

Revert "OpenGL: delete shaders and pipelines when they are not used any longer"

This reverts commit a57c1db878e2f8a7eb352c8f253db5488cdca6f6.

It produces a GL_INVALID_VALUE in ColorStateTest.ColorWriteMask

BUG=dawn:529

Change-Id: I3511057daf24baaf895b86cbda2a3a21e58d77fb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/65384
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

src/dawn_native/opengl/PipelineGL.h

diff --git a/src/dawn_native/opengl/PipelineGL.h b/src/dawn_native/opengl/PipelineGL.h
index be6c1dd..e210606 100644
--- a/src/dawn_native/opengl/PipelineGL.h
+++ b/src/dawn_native/opengl/PipelineGL.h
@@ -47,12 +47,12 @@
         const std::vector<GLuint>& GetTextureUnitsForTextureView(GLuint index) const;
         GLuint GetProgramHandle() const;
 
-      protected:
         void ApplyNow(const OpenGLFunctions& gl);
+
+      protected:
         MaybeError InitializeBase(const OpenGLFunctions& gl,
                                   const PipelineLayout* layout,
                                   const PerStage<ProgrammableStage>& stages);
-        void DeleteProgram(const OpenGLFunctions& gl);
 
       private:
         GLuint mProgram;