commit cb398e5294b8efebc6e81b87c48da7440c08efd3
author James Price <jrprice@google.com> Fri Jun 07 20:29:21 2024 +0000
committer James Price <jrprice@google.com> Fri Jun 07 20:29:21 2024 +0000
tree e92ca444dbf2969e3c1cbb2ab69045af3895eb0c
parent ec05c003b4df911ae8b1068bcd8473b7db74dbe5

Enable Tint IR by default for Vulkan

This enables the IR on Linux for the first time. Android was already
using it by default. ChromeOS is still controlled by the feature flag
for one more release as per Finch guidance, but now defaults to
enabled in both Chromium and Dawn.

Bug: 345276504
Include-Ci-Only-Tests: true
Change-Id: I6539981bda5c4413a4ec2708d8d7bf9f6a6322ab
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/192222
Reviewed-by: Austin Eng <enga@chromium.org>

src/dawn/native/vulkan/PhysicalDeviceVk.cpp

diff --git a/src/dawn/native/vulkan/PhysicalDeviceVk.cpp b/src/dawn/native/vulkan/PhysicalDeviceVk.cpp
index b7d9eb1..0555823 100644
--- a/src/dawn/native/vulkan/PhysicalDeviceVk.cpp
+++ b/src/dawn/native/vulkan/PhysicalDeviceVk.cpp
@@ -633,13 +633,14 @@
     // Vulkan SPEC and drivers.
     deviceToggles->Default(Toggle::UseTemporaryBufferInCompressedTextureToTextureCopy, true);
 
-#if DAWN_PLATFORM_IS(ANDROID)
-    // Default to the IR backend on Android.
-    deviceToggles->Default(Toggle::UseTintIR, true);
-#else
-    // All other platforms default to the value corresponding to the feature flag.
+    // TODO(crbug.com/345276504): Remove this and associated ShaderModuleVK code after M128 branch.
+#if DAWN_PLATFORM_IS(CHROMEOS)
+    // ChromeOS is controlled by the feature flag (which defaults to `true`) for one more release.
     deviceToggles->Default(Toggle::UseTintIR,
                            platform->IsFeatureEnabled(platform::Features::kWebGPUUseTintIR));
+#else
+    // All other Vulkan platforms are not controlled by the feature flag and use the IR by default.
+    deviceToggles->Default(Toggle::UseTintIR, true);
 #endif
 
     if (IsAndroidQualcomm()) {

src/dawn/platform/DawnPlatform.cpp

diff --git a/src/dawn/platform/DawnPlatform.cpp b/src/dawn/platform/DawnPlatform.cpp
index cb7cc68..a6772e4 100644
--- a/src/dawn/platform/DawnPlatform.cpp
+++ b/src/dawn/platform/DawnPlatform.cpp
@@ -101,7 +101,11 @@
             return false;
 #endif
         case Features::kWebGPUUseTintIR:
+#if defined(DAWN_OS_CHROMEOS)
+            return true;
+#else
             return false;
+#endif
     }
     return false;
 }